RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-07 Thread Pawel Laszczak
You have right. It's the operator priority issue. I've made this condition as separate "if" statement as suggested by Greg. V2 has been posted. Pawel > > >On 21-03-05 06:10:59, Pawel Laszczak wrote: >> From: Pawel Laszczak >> >> The value "start_cycle ? 0 : 1" in assignment caused >>

Re: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-06 Thread Greg KH
On Sat, Mar 06, 2021 at 08:53:42AM +0800, Peter Chen wrote: > On 21-03-05 06:10:59, Pawel Laszczak wrote: > > From: Pawel Laszczak > > > > The value "start_cycle ? 0 : 1" in assignment caused > > implicit truncation whole value to 1 byte. > > To fix the issue, an explicit casting has been added.

Re: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-05 Thread Peter Chen
On 21-03-05 06:10:59, Pawel Laszczak wrote: > From: Pawel Laszczak > > The value "start_cycle ? 0 : 1" in assignment caused > implicit truncation whole value to 1 byte. > To fix the issue, an explicit casting has been added. The root cause for this issue should be operator "|" priority higher

RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
vger.kernel.org; >linux-kernel@vger.kernel.org; Rahul Kumar ; >Sanket Parmar ; Pawel Laszczak >Subject: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB > >From: Pawel Laszczak > >The value "start_cycle ? 0 : 1" in assignment caused >implicit truncation whol

[PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
From: Pawel Laszczak The value "start_cycle ? 0 : 1" in assignment caused implicit truncation whole value to 1 byte. To fix the issue, an explicit casting has been added. Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Signed-off-by: Pawel Laszczak

[PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
From: Pawel Laszczak The value "start_cycle ? 0 : 1" in assignment caused implicit truncation whole value to 1 byte. To fix the issue, an explicit casting has been added. Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Signed-off-by: Pawel Laszczak