Re: [PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Alan Stern
On Tue, 29 Jan 2013, Vivek Gautam wrote: > This change de-asserts vbus_gpio on suspend and > re-asserts on resume in order to save power. > NOTE, this change means no USB charging in suspend > mode. Doing this would mean USB devices could not wake up the system. This would be unacceptable. How

Re: [PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
Hi Oliver, On Tue, Jan 29, 2013 at 5:07 PM, Oliver Neukum wrote: > On Tuesday 29 January 2013 16:22:45 Vivek Gautam wrote: >> This change de-asserts vbus_gpio on suspend and >> re-asserts on resume in order to save power. >> NOTE, this change means no USB charging in suspend >> mode. > > What ha

Re: [PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Oliver Neukum
On Tuesday 29 January 2013 16:22:45 Vivek Gautam wrote: > This change de-asserts vbus_gpio on suspend and > re-asserts on resume in order to save power. > NOTE, this change means no USB charging in suspend > mode. What happens if a device on the bus is a source of wakeups? Regards

[PATCH] usb: ehci: s5p: Power-off VBUS during suspend.

2013-01-29 Thread Vivek Gautam
This change de-asserts vbus_gpio on suspend and re-asserts on resume in order to save power. NOTE, this change means no USB charging in suspend mode. Signed-off-by: Vivek Gautam CC: Doug Anderson --- Based on 'usb-next'. drivers/usb/host/ehci-s5p.c | 29 ++--- 1 file