Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-23 Thread Evgeny Novikov
23.07.2020, 04:00, "Alan Stern" : > On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote: >>  Hi Alan, >> >>  I have neither an appropriate hardware nor an experience to deal with >>  issues that you mentioned. Our framework does not allow to detect them >>  as well at the moment. At

Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-22 Thread Alan Stern
On Thu, Jul 23, 2020 at 10:59:06AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2020-07-22 at 22:56 +0300, Evgeny Novikov wrote: > > Hi Alan, > > > > I have neither an appropriate hardware nor an experience to deal with > > issues that you mentioned. Our framework does not allow to detect > >

Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-22 Thread Alan Stern
On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote: > Hi Alan, > > I have neither an appropriate hardware nor an experience to deal with > issues that you mentioned. Our framework does not allow to detect them > as well at the moment. At last, it seems that rather many drivers can

Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-22 Thread Benjamin Herrenschmidt
On Wed, 2020-07-22 at 22:56 +0300, Evgeny Novikov wrote: > Hi Alan, > > I have neither an appropriate hardware nor an experience to deal with > issues that you mentioned. Our framework does not allow to detect > them as well at the moment. At last, it seems that rather many > drivers can suffer

Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-22 Thread Evgeny Novikov
Hi Alan, I have neither an appropriate hardware nor an experience to deal with issues that you mentioned. Our framework does not allow to detect them as well at the moment. At last, it seems that rather many drivers can suffer from these issues. So, it would be much better if somebody else

Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-22 Thread Alan Stern
On Tue, Jul 21, 2020 at 11:15:58PM +0300, Evgeny Novikov wrote: > Driver does not release memory for device on error handling paths in > net2280_probe() when gadget_release() is not registered yet. > > The patch fixes the bug like in other similar drivers. > > Found by Linux Driver Verification

[PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

2020-07-21 Thread Evgeny Novikov
Driver does not release memory for device on error handling paths in net2280_probe() when gadget_release() is not registered yet. The patch fixes the bug like in other similar drivers. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov ---