Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman wrote: > On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > > Replace all hardcoded ttyGS strings with the PREFIX macro. > > Why? Because IMHO if PREFIX is available it should be used everywhere

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: Replace all hardcoded ttyGS strings with the PREFIX macro. Why? Because IMHO if PREFIX is available it

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Greg Kroah-Hartman
On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > Replace all hardcoded ttyGS strings with the PREFIX macro. Why? > Therefore the PREFIX definition is moved to u_serial.h. Why? > Furthermore the modified files are checkpatch.pl compliant now. You are doing two different

[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner --- drivers/usb/gadget/f_acm.c| 49 +

[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/usb/gadget/f_acm.c| 49

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Greg Kroah-Hartman
On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: Replace all hardcoded ttyGS strings with the PREFIX macro. Why? Therefore the PREFIX definition is moved to u_serial.h. Why? Furthermore the modified files are checkpatch.pl compliant now. You are doing two different things