Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-11 Thread Chunfeng Yun
On Fri, 2019-10-11 at 13:35 +0900, Tomasz Figa wrote: > On Thu, Oct 10, 2019 at 7:59 PM Chunfeng Yun > wrote: > > > > On Thu, 2019-10-10 at 18:00 +0900, Tomasz Figa wrote: > > > Hi Chunfeng, > > > > > > On Thu, Oct 10, 2019 at 5:45 PM Chunfeng Yun > > > wrote: > > > > > > > > Hi, Tomasz, > > >

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Tomasz Figa
On Thu, Oct 10, 2019 at 7:59 PM Chunfeng Yun wrote: > > On Thu, 2019-10-10 at 18:00 +0900, Tomasz Figa wrote: > > Hi Chunfeng, > > > > On Thu, Oct 10, 2019 at 5:45 PM Chunfeng Yun > > wrote: > > > > > > Hi, Tomasz, > > > > > > On Thu, 2019-10-10 at 16:50 +0900, Tomasz Figa wrote: > > > >

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Chunfeng Yun
On Thu, 2019-10-10 at 18:00 +0900, Tomasz Figa wrote: > Hi Chunfeng, > > On Thu, Oct 10, 2019 at 5:45 PM Chunfeng Yun > wrote: > > > > Hi, Tomasz, > > > > On Thu, 2019-10-10 at 16:50 +0900, Tomasz Figa wrote: > > > MediaTek XHCI host controller does not support 64-bit addressing despite > > >

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Tomasz Figa
On Thu, Oct 10, 2019 at 6:37 PM Nicolas Boichat wrote: > > On Thu, Oct 10, 2019 at 5:11 PM Tomasz Figa wrote: > > > > On Thu, Oct 10, 2019 at 6:08 PM Nicolas Boichat > > wrote: > > > > > > On Thu, Oct 10, 2019 at 3:50 PM Tomasz Figa wrote: > > > > > > > > MediaTek XHCI host controller does

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Nicolas Boichat
On Thu, Oct 10, 2019 at 5:11 PM Tomasz Figa wrote: > > On Thu, Oct 10, 2019 at 6:08 PM Nicolas Boichat wrote: > > > > On Thu, Oct 10, 2019 at 3:50 PM Tomasz Figa wrote: > > > > > > MediaTek XHCI host controller does not support 64-bit addressing despite > > > the AC64 bit of HCCPARAMS1 register

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Tomasz Figa
On Thu, Oct 10, 2019 at 6:08 PM Nicolas Boichat wrote: > > On Thu, Oct 10, 2019 at 3:50 PM Tomasz Figa wrote: > > > > MediaTek XHCI host controller does not support 64-bit addressing despite > > the AC64 bit of HCCPARAMS1 register being set. The platform-specific > > glue sets the DMA mask to 32

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Nicolas Boichat
On Thu, Oct 10, 2019 at 3:50 PM Tomasz Figa wrote: > > MediaTek XHCI host controller does not support 64-bit addressing despite > the AC64 bit of HCCPARAMS1 register being set. The platform-specific > glue sets the DMA mask to 32 bits on its own, but it has no effect, > because xhci_gen_setup()

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Tomasz Figa
Hi Chunfeng, On Thu, Oct 10, 2019 at 5:45 PM Chunfeng Yun wrote: > > Hi, Tomasz, > > On Thu, 2019-10-10 at 16:50 +0900, Tomasz Figa wrote: > > MediaTek XHCI host controller does not support 64-bit addressing despite > > the AC64 bit of HCCPARAMS1 register being set. The platform-specific > >

Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Chunfeng Yun
Hi, Tomasz, On Thu, 2019-10-10 at 16:50 +0900, Tomasz Figa wrote: > MediaTek XHCI host controller does not support 64-bit addressing despite > the AC64 bit of HCCPARAMS1 register being set. The platform-specific > glue sets the DMA mask to 32 bits on its own, but it has no effect, > because

[PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk

2019-10-10 Thread Tomasz Figa
MediaTek XHCI host controller does not support 64-bit addressing despite the AC64 bit of HCCPARAMS1 register being set. The platform-specific glue sets the DMA mask to 32 bits on its own, but it has no effect, because xhci_gen_setup() overrides it according to hardware capabilities. Use the