Re: [PATCH] usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()

2019-10-01 Thread Guenter Roeck
On 10/1/19 4:54 AM, Dan Carpenter wrote: On Thu, Sep 26, 2019 at 05:53:10AM -0700, Guenter Roeck wrote: On Wed, Sep 25, 2019 at 02:02:19PM +0300, Dan Carpenter wrote: The "port->typec_caps.data" and "port->typec_caps.type" variables are enums and in this context GCC will treat them as an

Re: [PATCH] usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()

2019-10-01 Thread Dan Carpenter
On Thu, Sep 26, 2019 at 05:53:10AM -0700, Guenter Roeck wrote: > On Wed, Sep 25, 2019 at 02:02:19PM +0300, Dan Carpenter wrote: > > The "port->typec_caps.data" and "port->typec_caps.type" variables are > > enums and in this context GCC will treat them as an unsigned int so they > > can never be

Re: [PATCH] usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()

2019-09-26 Thread Guenter Roeck
On Wed, Sep 25, 2019 at 02:02:19PM +0300, Dan Carpenter wrote: > The "port->typec_caps.data" and "port->typec_caps.type" variables are > enums and in this context GCC will treat them as an unsigned int so they > can never be less than zero. > > Fixes: ae8a2ca8a221 ("usb: typec: Group all

[PATCH] usb: typec: tcpm: Fix a signedness bug in tcpm_fw_get_caps()

2019-09-25 Thread Dan Carpenter
The "port->typec_caps.data" and "port->typec_caps.type" variables are enums and in this context GCC will treat them as an unsigned int so they can never be less than zero. Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together") Signed-off-by: Dan Carpenter ---