On Fri, Jul 26, 2013 at 01:56:19PM +0800, Barry Song wrote:
> 2013/7/18 Felipe Balbi :
> > On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
> >> Hi Felipe,
> >>
> >> Thanks, I'll test the patch.
> >>
> >> But sysfs_notify(>dev.kobj, NULL, "status"), status or state ?
> >> I notice that
On Fri, Jul 26, 2013 at 01:56:19PM +0800, Barry Song wrote:
2013/7/18 Felipe Balbi ba...@ti.com:
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ?
I notice that
2013/7/18 Felipe Balbi :
> On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
>> Hi Felipe,
>>
>> Thanks, I'll test the patch.
>>
>> But sysfs_notify(>dev.kobj, NULL, "status"), status or state ?
>> I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
>
> good eyes,
2013/7/18 Felipe Balbi ba...@ti.com:
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
good eyes,
2013/7/18 Greg KH :
> On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
>> Hi,
>>
>> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> > > The question is since we default GADGET, so the g_mass_storage.ko is
>> > > installed early but connecting to a host PC
>> > > is
2013/7/18 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is
Hi,
On Thu, Jul 18, 2013 at 09:50:37AM -0400, Alan Stern wrote:
> On Thu, 18 Jul 2013, Felipe Balbi wrote:
>
> > > > yes. Only the UDC driver knows when the controller is moving among those
> > > > states.
> > >
> > > Not quite. Only the gadget driver knows when the transition between
> > >
Hi,
On Thu, Jul 18, 2013 at 09:50:37AM -0400, Alan Stern wrote:
On Thu, 18 Jul 2013, Felipe Balbi wrote:
yes. Only the UDC driver knows when the controller is moving among those
states.
Not quite. Only the gadget driver knows when the transition between
ADDRESS and
>
> On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen
> wrote:
> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> >> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> >> > Hi Greg,
> >> >
> >> > The USB on our platform can change roles between HOST and GADGET,
> but
> >> >
On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen peter.c...@freescale.com
wrote:
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
Hi Greg,
The USB on our platform can change roles between HOST and GADGET,
but
it
On Thu, 18 Jul 2013, Felipe Balbi wrote:
> > > yes. Only the UDC driver knows when the controller is moving among those
> > > states.
> >
> > Not quite. Only the gadget driver knows when the transition between
> > ADDRESS and CONFIGURED occurs. This should be added to composite.c.
>
> that's
On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> Here's the patch. If you are OK with it, I'll send it to the list formally.
> Thanks.
>
> -
>
> usb: gadget: udc-core: make
Hi Felipe,
Here's the patch. If you are OK with it, I'll send it to the list formally.
Thanks.
-
usb: gadget: udc-core: make udc state attribute name consistent
The name of udc state attribute file
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> Thanks, I'll test the patch.
>
> But sysfs_notify(>dev.kobj, NULL, "status"), status or state ?
> I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
good eyes, please send a patch which I'll queue on
Hi,
On Thu, Jul 18, 2013 at 11:40:41AM +0300, Felipe Balbi wrote:
> > >> >> > The question is since we default GADGET, so the g_mass_storage.ko is
> > >> >> > installed early but connecting to a host PC
> > >> >> > is randomly, But the udev has no idea when a host PC connects our
> > >> >> >
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(>dev.kobj, NULL, "status"), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
On Thu, Jul 18, 2013 at 4:40 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wang
Hi,
On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wang wrote:
> On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi wrote:
> > On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> >> Hi Felipe,
> >>
> >> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> >> > Hi,
> >> >
> >> > On Mon,
On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi wrote:
> On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
>> Hi Felipe,
>>
>> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> >> > The question is since we
Hi Peter,
On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen wrote:
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
>> > Hi Greg,
>> >
>> > The USB on our platform can change roles between HOST and GADGET, but
>> > it is not
Hi,
On Wed, Jul 17, 2013 at 11:37:35AM -0400, Alan Stern wrote:
> On Wed, 17 Jul 2013, Felipe Balbi wrote:
>
> > On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> > > Hi Felipe,
> > >
> > > On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > > > Hi,
> > > >
> > > > On Mon, Jul
Hi,
On Wed, Jul 17, 2013 at 11:37:35AM -0400, Alan Stern wrote:
On Wed, 17 Jul 2013, Felipe Balbi wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013 at
Hi Peter,
On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen peter.c...@freescale.com wrote:
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it
On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi ba...@ti.com wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since
Hi,
On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wang wrote:
On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi ba...@ti.com wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon,
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
On Thu, Jul 18, 2013 at 4:40 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Jul 18, 2013 at 04:33:43PM +0800,
Hi,
On Thu, Jul 18, 2013 at 11:40:41AM +0300, Felipe Balbi wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is randomly, But the udev has no idea when a host PC connects our
device.
So we
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(gadget-dev.kobj, NULL, status), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
good eyes, please send a patch which I'll queue on
Hi Felipe,
Here's the patch. If you are OK with it, I'll send it to the list formally.
Thanks.
-
usb: gadget: udc-core: make udc state attribute name consistent
The name of udc state attribute file
On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
Hi Felipe,
Here's the patch. If you are OK with it, I'll send it to the list formally.
Thanks.
-
usb: gadget: udc-core: make udc
On Thu, 18 Jul 2013, Felipe Balbi wrote:
yes. Only the UDC driver knows when the controller is moving among those
states.
Not quite. Only the gadget driver knows when the transition between
ADDRESS and CONFIGURED occurs. This should be added to composite.c.
that's not entirely
On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > > The question is since we default GADGET, so the g_mass_storage.ko is
> > > installed early but connecting to a host PC
> > > is randomly, But the udev has no idea
On Wed, 17 Jul 2013, Felipe Balbi wrote:
> On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> > Hi Felipe,
> >
> > On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > >> > The question is since we
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> >> > The question is since we default GADGET, so the g_mass_storage.ko is
> >> > installed
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> > The question is since we default GADGET, so the g_mass_storage.ko is
>> > installed early but connecting to a host PC
>> > is randomly, But the udev has no idea
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > The question is since we default GADGET, so the g_mass_storage.ko is
> > installed early but connecting to a host PC
> > is randomly, But the udev has no idea when a host PC connects our device.
> >
> > So we consider it's
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is randomly, But the udev has no idea when a host PC connects our device.
So we consider it's reasonable to let
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is randomly, But the udev has no idea
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early
On Wed, 17 Jul 2013, Felipe Balbi wrote:
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default
On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
The question is since we default GADGET, so the g_mass_storage.ko is
installed early but connecting to a host PC
is randomly, But the udev has no idea when a host
Hi Greg,
On Tue, Jul 16, 2013 at 2:31 PM, Greg KH wrote:
> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
>> Hi Greg,
>>
>> The USB on our platform can change roles between HOST and GADGET, but
>> it is not capable of OTG.
>
> That kind of sounds like the definition of OTG :)
Yes.
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> > Hi Greg,
> >
> > The USB on our platform can change roles between HOST and GADGET, but
> > it is not capable of OTG.
>
> That kind of sounds like the definition of OTG :)
>
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> Hi Greg,
>
> The USB on our platform can change roles between HOST and GADGET, but
> it is not capable of OTG.
That kind of sounds like the definition of OTG :)
> When the USB changes between roles the udev will run some scripts
>
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
That kind of sounds like the definition of OTG :)
When the USB changes between roles the udev will run some scripts
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
That kind of sounds like the definition of OTG :)
When the
Hi Greg,
On Tue, Jul 16, 2013 at 2:31 PM, Greg KH gre...@linuxfoundation.org wrote:
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
That kind of sounds like the definition of
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
When the USB changes between roles the udev will run some scripts
automatically according to the udev rules.
The default role is GADGET, and we bind the g_mass_storage to the USB
GADGET role.
On Mon, Jul 15, 2013 at 11:57:24AM +0800, Rong Wang wrote:
> usb: udc: add gadget state kobject uevent
>
> Add USB_UDC_STATE environment variable in udc uevent
> callback and trigger kobject_uevent in usb_gadget_set_state
> to inform the user-space the state of the gadget.
Why?
On Mon, Jul 15, 2013 at 11:57:24AM +0800, Rong Wang wrote:
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Why?
And
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
When the USB changes between roles the udev will run some scripts
automatically according to the udev rules.
The default role is GADGET, and we bind the g_mass_storage to the USB
GADGET role.
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang
diff --git a/drivers/usb/gadget/udc-core.c
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang
diff --git a/drivers/usb/gadget/udc-core.c
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang rong.w...@csr.com
diff --git
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang rong.w...@csr.com
diff --git
54 matches
Mail list logo
