Re: [PATCH] vc04_services: Fixing coding and logical guidelines

2017-03-14 Thread Pushkar Jambhlekar
Thanks. I will rewrite patch according to the suggestions. On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote: >> Description: > > No need for that line. > >> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c',

Re: [PATCH] vc04_services: Fixing coding and logical guidelines

2017-03-14 Thread Greg Kroah-Hartman
On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote: > Description: No need for that line. > in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes > to make code according to 'checkpath.pl'. Why indent? Also, you need to be specific as to what type of chan

[PATCH] vc04_services: Fixing coding and logical guidelines

2017-03-14 Thread Pushkar Jambhlekar
Description: in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'. Also, fixing logical issue, i.e. removing break after goto statement. Signed-off-by: Pushkar Jambhlekar --- .../vc04_services/interface/vchiq_arm/vchiq_shim.c | 33