Re: [PATCH] venus: venc: add handling for VIDIOC_ENCODER_CMD

2020-10-22 Thread dikshita
Hi Alex, Thanks for your suggestion, the helpers are good but it is complicated to use them in video deriver as video driver needs to deal with FW interface and wait for buffer processing from FW. So these helpers can't be used directly. For example in case of B frames, to encode such frame FW

Re: [PATCH] venus: venc: add handling for VIDIOC_ENCODER_CMD

2020-10-20 Thread Alexandre Courbot
Hi Dikshita, On Mon, Oct 19, 2020 at 11:29 PM Dikshita Agarwal wrote: > > Add handling for below commands in encoder: > 1. V4L2_ENC_CMD_STOP > 2. V4L2_ENC_CMD_START I suspect this can be implemented more easily (and more safely) using the m2m encoder helpers introduced recently. Please see this

[PATCH] venus: venc: add handling for VIDIOC_ENCODER_CMD

2020-10-19 Thread Dikshita Agarwal
Add handling for below commands in encoder: 1. V4L2_ENC_CMD_STOP 2. V4L2_ENC_CMD_START Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/core.h | 9 + drivers/media/platform/qcom/venus/venc.c | 64 +++- 2 files changed, 72 insertions(+), 1