Re: [PATCH] vfio/pci: Clear error and request eventfd ctx after releasing

2020-06-17 Thread Daniel Wagner
Hi Alex, On Tue, Jun 16, 2020 at 03:26:36PM -0600, Alex Williamson wrote: > The next use of the device will generate an underflow from the > stale reference. > > Cc: Qian Cai > Fixes: 1518ac272e78 ("vfio/pci: fix memory leaks of eventfd ctx") > Reported-by: Daniel Wagner > Signed-off-by: Alex

Re: [PATCH] vfio/pci: Clear error and request eventfd ctx after releasing

2020-06-16 Thread Cornelia Huck
On Tue, 16 Jun 2020 15:26:36 -0600 Alex Williamson wrote: > The next use of the device will generate an underflow from the > stale reference. > > Cc: Qian Cai > Fixes: 1518ac272e78 ("vfio/pci: fix memory leaks of eventfd ctx") > Reported-by: Daniel Wagner > Signed-off-by: Alex Williamson >

Re: [PATCH] vfio/pci: Clear error and request eventfd ctx after releasing

2020-06-16 Thread Qian Cai
> On Jun 16, 2020, at 5:26 PM, Alex Williamson > wrote: > > The next use of the device will generate an underflow from the > stale reference. Thanks Alex for taking care of this. I suppose my tests were too basic and never able to catch this underflow in the first place.

[PATCH] vfio/pci: Clear error and request eventfd ctx after releasing

2020-06-16 Thread Alex Williamson
The next use of the device will generate an underflow from the stale reference. Cc: Qian Cai Fixes: 1518ac272e78 ("vfio/pci: fix memory leaks of eventfd ctx") Reported-by: Daniel Wagner Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 ++-- 1 file changed, 6