Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-11 Thread David Miller
From: Zha Bin Date: Tue, 8 Jan 2019 16:07:03 +0800 > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero. This inconsistency causes one bug in vhost vsock driver. The > scenarios is: > > 0. A

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-10 Thread Jason Wang
On 2019/1/8 下午4:07, Zha Bin wrote: The vsock core only supports 32bit CID, but the Virtio-vsock spec define CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as zero. This inconsistency causes one bug in vhost vsock driver. The scenarios is: 0. A hash table

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-09 Thread Christian Borntraeger
Adding Peter, is this the same problem that you reported me today? Can you test Zha Bins patch? Christian On 08.01.2019 09:07, Zha Bin wrote: > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero.

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-08 Thread Stefan Hajnoczi
On Tue, Jan 08, 2019 at 04:07:03PM +0800, Zha Bin wrote: > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero. This inconsistency causes one bug in vhost vsock driver. The > scenarios is: > > 0.

[PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-08 Thread Zha Bin
The vsock core only supports 32bit CID, but the Virtio-vsock spec define CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as zero. This inconsistency causes one bug in vhost vsock driver. The scenarios is: 0. A hash table (vhost_vsock_hash) is used to map an CID to a vsock