Re: [PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

2020-05-09 Thread Sam Ravnborg
Hi Jason. On Wed, May 06, 2020 at 02:17:45PM +0800, Jason Yan wrote: > No other functions use the return value of pxa168fb_init_mode() and the > return value is always 0 now. Make it return void. This fixes the > following coccicheck warning: > > drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded v

Re: [PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

2020-05-09 Thread Sam Ravnborg
Hi Jason. On Wed, May 06, 2020 at 02:17:45PM +0800, Jason Yan wrote: > No other functions use the return value of pxa168fb_init_mode() and the > return value is always 0 now. Make it return void. This fixes the > following coccicheck warning: > > drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded v

[PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

2020-05-05 Thread Jason Yan
No other functions use the return value of pxa168fb_init_mode() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded variable: "ret". Return "0" on line 597 Signed-off-by: Jason Yan --- drivers/v