Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-25 Thread Martin Kaiser
Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > > ok, understood. I wasn't able to dig up an imx1 specification. Do you > > know if it's publicly available? > http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM.pdf Thanks. > So you put the values to use in

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-25 Thread Martin Kaiser
Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > > ok, understood. I wasn't able to dig up an imx1 specification. Do you > > know if it's publicly available? > http://www.nxp.com/assets/documents/data/en/reference-manuals/MC9328MX1RM.pdf Thanks. > So you put the values to use in

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-23 Thread Uwe Kleine-König
On Wed, Nov 23, 2016 at 10:31:13AM +0100, Martin Kaiser wrote: > Hello Uwe, all, > > Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > > > For the MX1 which is also supported by this driver, the definitions are > > right. > > ok, understood. I wasn't able to dig up an imx1

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-23 Thread Uwe Kleine-König
On Wed, Nov 23, 2016 at 10:31:13AM +0100, Martin Kaiser wrote: > Hello Uwe, all, > > Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > > > For the MX1 which is also supported by this driver, the definitions are > > right. > > ok, understood. I wasn't able to dig up an imx1

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-23 Thread Martin Kaiser
Hello Uwe, all, Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > For the MX1 which is also supported by this driver, the definitions are > right. ok, understood. I wasn't able to dig up an imx1 specification. Do you know if it's publicly available? > So this needs a more

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-23 Thread Martin Kaiser
Hello Uwe, all, Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > For the MX1 which is also supported by this driver, the definitions are > right. ok, understood. I wasn't able to dig up an imx1 specification. Do you know if it's publicly available? > So this needs a more

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-22 Thread Uwe Kleine-König
On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote: > The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. > Use the correct mask to allow setting all possible bits. > > Signed-off-by: Martin Kaiser > --- > > This bug was discovered on a board that

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-22 Thread Uwe Kleine-König
On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote: > The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. > Use the correct mask to allow setting all possible bits. > > Signed-off-by: Martin Kaiser > --- > > This bug was discovered on a board that uses

[PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-21 Thread Martin Kaiser
The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. Use the correct mask to allow setting all possible bits. Signed-off-by: Martin Kaiser --- This bug was discovered on a board that uses DMACR_TM(16). We ended up with TM==0 in the register, the upper three

[PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

2016-11-21 Thread Martin Kaiser
The HM and TM fields in the LCDC DMA Control Register are 7 bits wide. Use the correct mask to allow setting all possible bits. Signed-off-by: Martin Kaiser --- This bug was discovered on a board that uses DMACR_TM(16). We ended up with TM==0 in the register, the upper three bits were filtered