Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Rusty Russell
Lee Jones writes: >> > Resorted to poaching now have we Pawel? > >> I hope you were joking! > > Yes, of course. I thought that was clearly indicated by the jovial winking > smiley. :) > > I realise it wasn't obvious soley by this exchange, but Pawel and I are > actually ol' friends. > >> Doing

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-08 Thread Rusty Russell
Lee Jones lee.jo...@linaro.org writes: Resorted to poaching now have we Pawel? I hope you were joking! Yes, of course. I thought that was clearly indicated by the jovial winking smiley. :) I realise it wasn't obvious soley by this exchange, but Pawel and I are actually ol' friends.

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-07 Thread Rusty Russell
Lee Jones writes: > On Mon, 05 Nov 2012, Pawel Moll wrote: > >> On 64-bit machines resource_size_t is a 64-bit value, while >> sscanf() format for this argument was defined as "%u". Fixed >> by using an intermediate local value of a known length. >> >> Also added cleaned up the resource creation

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-07 Thread Rusty Russell
Lee Jones lee.jo...@linaro.org writes: On Mon, 05 Nov 2012, Pawel Moll wrote: On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as %u. Fixed by using an intermediate local value of a known length. Also added cleaned up the resource

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Pawel Moll wrote: > On Mon, 2012-11-05 at 13:44 +, Lee Jones wrote: > > On Mon, 05 Nov 2012, Pawel Moll wrote: > > > > > On 64-bit machines resource_size_t is a 64-bit value, while > > > sscanf() format for this argument was defined as "%u". Fixed > > > by using an

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Pawel Moll
On Mon, 2012-11-05 at 13:44 +, Lee Jones wrote: > On Mon, 05 Nov 2012, Pawel Moll wrote: > > > On 64-bit machines resource_size_t is a 64-bit value, while > > sscanf() format for this argument was defined as "%u". Fixed > > by using an intermediate local value of a known length. > > > > Also

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Pawel Moll wrote: > On 64-bit machines resource_size_t is a 64-bit value, while > sscanf() format for this argument was defined as "%u". Fixed > by using an intermediate local value of a known length. > > Also added cleaned up the resource creation and adde extra > comments

[PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Pawel Moll
On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as "%u". Fixed by using an intermediate local value of a known length. Also added cleaned up the resource creation and adde extra comments to make the parameters parsing easier to follow.

[PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Pawel Moll
On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as %u. Fixed by using an intermediate local value of a known length. Also added cleaned up the resource creation and adde extra comments to make the parameters parsing easier to follow.

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Pawel Moll wrote: On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as %u. Fixed by using an intermediate local value of a known length. Also added cleaned up the resource creation and adde extra comments to make

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Pawel Moll
On Mon, 2012-11-05 at 13:44 +, Lee Jones wrote: On Mon, 05 Nov 2012, Pawel Moll wrote: On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as %u. Fixed by using an intermediate local value of a known length. Also added cleaned

Re: [PATCH] virtio-mmio: Fix irq parsing in command line parameter

2012-11-05 Thread Lee Jones
On Mon, 05 Nov 2012, Pawel Moll wrote: On Mon, 2012-11-05 at 13:44 +, Lee Jones wrote: On Mon, 05 Nov 2012, Pawel Moll wrote: On 64-bit machines resource_size_t is a 64-bit value, while sscanf() format for this argument was defined as %u. Fixed by using an intermediate local