Re: [PATCH] virtio_pci: use 16-bit accessor for queue_enable.

2015-02-09 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 05:05:01PM +1030, Rusty Russell wrote: > Since PCI is little endian, 8-bit access might work, but the spec section > is very clear on this: > > 4.1.3.1 Driver Requirements: PCI Device Layout > > The driver MUST access each field using the “natural” access method, >

[PATCH] virtio_pci: use 16-bit accessor for queue_enable.

2015-02-09 Thread Rusty Russell
Since PCI is little endian, 8-bit access might work, but the spec section is very clear on this: 4.1.3.1 Driver Requirements: PCI Device Layout The driver MUST access each field using the “natural” access method, i.e. 32-bit accesses for 32-bit fields, 16-bit accesses for 16-bit fields

Re: [PATCH] virtio_pci: use 16-bit accessor for queue_enable.

2015-02-09 Thread Michael S. Tsirkin
On Tue, Feb 10, 2015 at 05:05:01PM +1030, Rusty Russell wrote: Since PCI is little endian, 8-bit access might work, but the spec section is very clear on this: 4.1.3.1 Driver Requirements: PCI Device Layout The driver MUST access each field using the “natural” access method, i.e.

[PATCH] virtio_pci: use 16-bit accessor for queue_enable.

2015-02-09 Thread Rusty Russell
Since PCI is little endian, 8-bit access might work, but the spec section is very clear on this: 4.1.3.1 Driver Requirements: PCI Device Layout The driver MUST access each field using the “natural” access method, i.e. 32-bit accesses for 32-bit fields, 16-bit accesses for 16-bit fields