RE: [PATCH] vsock: Fix a lockdep warning in __vsock_release()

2019-09-25 Thread Dexuan Cui
> From: Stefano Garzarella > Sent: Thursday, August 22, 2019 3:25 AM > > [...snipped...] > > --- a/net/vmw_vsock/hyperv_transport.c > > +++ b/net/vmw_vsock/hyperv_transport.c > > @@ -559,7 +559,7 @@ static void hvs_release(struct vsock_sock *vsk) > > struct sock *sk = sk_vsock(vsk); > >

Re: [PATCH] vsock: Fix a lockdep warning in __vsock_release()

2019-08-22 Thread Stefano Garzarella
On Tue, Aug 20, 2019 at 03:14:22AM +, Dexuan Cui wrote: > Lockdep is unhappy if two locks from the same class are held. > > Fix the below warning by making __vsock_release() non-recursive -- this > patch is kind of ugly, but it looks to me there is not a better way to > deal with the problem

Re: [PATCH] vsock: Fix a lockdep warning in __vsock_release()

2019-08-20 Thread David Miller
From: Dexuan Cui Date: Tue, 20 Aug 2019 03:14:22 + > +static void __vsock_release2(struct sock *sk) Do not duplicate an entire function just to adjust some aspect of the lock debugging, please find a cleaner and more minimal way to implement this fix.

[PATCH] vsock: Fix a lockdep warning in __vsock_release()

2019-08-19 Thread Dexuan Cui
Lockdep is unhappy if two locks from the same class are held. Fix the below warning by making __vsock_release() non-recursive -- this patch is kind of ugly, but it looks to me there is not a better way to deal with the problem here. WARNING: possible