Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Doug Anderson
Guenter and Olof, On Mon, Dec 2, 2013 at 1:36 PM, Guenter Roeck wrote: > On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: >> On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: >> > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: >> >> A good watchdog driver is su

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Doug Anderson
Tomasz, On Thu, Dec 5, 2013 at 8:21 AM, Tomasz Figa wrote: > Hi Doug, > > Please see my comments inline. > > On Monday 02 of December 2013 10:14:41 Doug Anderson wrote: >> A good watchdog driver is supposed to report when it was responsible >> for resetting the system. Implement this for the s3c

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Doug Anderson
Tomasz On Thu, Dec 5, 2013 at 8:18 AM, Tomasz Figa wrote: > On Thursday 05 of December 2013 08:00:27 Guenter Roeck wrote: >> On Thu, Dec 05, 2013 at 01:27:13PM +0530, Leela Krishna Amudala wrote: >> > Hi Guenter Roeck, >> > >> > On Tue, Dec 3, 2013 at 3:06 AM, Guenter Roeck wrote: >> > > >> > >

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Doug Anderson
Guenter, On Thu, Dec 5, 2013 at 8:40 AM, Guenter Roeck wrote: > On Thu, Dec 05, 2013 at 05:21:47PM +0100, Tomasz Figa wrote: >> Hi Doug, >> >> Please see my comments inline. >> >> On Monday 02 of December 2013 10:14:41 Doug Anderson wrote: >> > A good watchdog driver is supposed to report when it

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Tomasz Figa
On Thursday 05 of December 2013 08:40:38 Guenter Roeck wrote: > On Thu, Dec 05, 2013 at 05:21:47PM +0100, Tomasz Figa wrote: > > Hi Doug, > > > > Please see my comments inline. > > > > On Monday 02 of December 2013 10:14:41 Doug Anderson wrote: > > > A good watchdog driver is supposed to report w

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Guenter Roeck
On Thu, Dec 05, 2013 at 05:21:47PM +0100, Tomasz Figa wrote: > Hi Doug, > > Please see my comments inline. > > On Monday 02 of December 2013 10:14:41 Doug Anderson wrote: > > A good watchdog driver is supposed to report when it was responsible > > for resetting the system. Implement this for the

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Tomasz Figa
Hi Doug, Please see my comments inline. On Monday 02 of December 2013 10:14:41 Doug Anderson wrote: > A good watchdog driver is supposed to report when it was responsible > for resetting the system. Implement this for the s3c2410, at least on > exynos5250 and exynos5420 where we already have a p

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Tomasz Figa
On Thursday 05 of December 2013 08:00:27 Guenter Roeck wrote: > On Thu, Dec 05, 2013 at 01:27:13PM +0530, Leela Krishna Amudala wrote: > > Hi Guenter Roeck, > > > > On Tue, Dec 3, 2013 at 3:06 AM, Guenter Roeck wrote: > > > > > > On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: > >

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-05 Thread Guenter Roeck
On Thu, Dec 05, 2013 at 01:27:13PM +0530, Leela Krishna Amudala wrote: > Hi Guenter Roeck, > > On Tue, Dec 3, 2013 at 3:06 AM, Guenter Roeck wrote: > > > > On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: > > > On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > > > > On Mon,

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-04 Thread Leela Krishna Amudala
Hi Guenter Roeck, On Tue, Dec 3, 2013 at 3:06 AM, Guenter Roeck wrote: > > On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: > > On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > > > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: > > >> A good watchdog driver

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-02 Thread Guenter Roeck
On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: > On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: > >> A good watchdog driver is supposed to report when it was responsible > >> for resetting the system. Imple

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-02 Thread Doug Anderson
Guenter and Olof, On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: >> A good watchdog driver is supposed to report when it was responsible >> for resetting the system. Implement this for the s3c2410, at least on >> exynos5250

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-02 Thread Olof Johansson
On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck wrote: > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: >> A good watchdog driver is supposed to report when it was responsible >> for resetting the system. Implement this for the s3c2410, at least on >> exynos5250 and exynos5420 wher

Re: [PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-02 Thread Guenter Roeck
On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: > A good watchdog driver is supposed to report when it was responsible > for resetting the system. Implement this for the s3c2410, at least on > exynos5250 and exynos5420 where we already have a pointer to the PMU > registers to read t

[PATCH] watchdog: s3c2410_wdt: Report when the watchdog reset the system

2013-12-02 Thread Doug Anderson
A good watchdog driver is supposed to report when it was responsible for resetting the system. Implement this for the s3c2410, at least on exynos5250 and exynos5420 where we already have a pointer to the PMU registers to read the information. Signed-off-by: Doug Anderson --- This patch is based