Re: [PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()'

2020-05-11 Thread Kalle Valo
Christophe JAILLET wrote: > In case of error, 'qcom_wcnss_open_channel()' must be undone by a call to > 'rpmsg_destroy_ept()', as already done in the remove function. > > Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to > rpmsg") > Signed-off-by: Christophe JAILLET

Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

2020-05-07 Thread Kalle Valo
Markus Elfring writes: > … >> +++ b/drivers/net/wireless/ath/wcn36xx/main.c > … >> @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev) >> out_unmap: >> iounmap(wcn->ccu_base); >> iounmap(wcn->dxe_base); >> +out_channel: >> +

Re: [PATCH] wcn36xx: Fix error handling path in wcn36xx_probe()

2020-05-07 Thread Markus Elfring
… > +++ b/drivers/net/wireless/ath/wcn36xx/main.c … > @@ -1359,6 +1359,8 @@ static int wcn36xx_probe(struct platform_device *pdev) > out_unmap: > iounmap(wcn->ccu_base); > iounmap(wcn->dxe_base); > +out_channel: > + rpmsg_destroy_ept(wcn->smd_channel); > out_wq: >

Re: [PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()'

2020-05-06 Thread Bjorn Andersson
On Wed 06 May 21:36 PDT 2020, Christophe JAILLET wrote: > In case of error, 'qcom_wcnss_open_channel()' must be undone by a call to > 'rpmsg_destroy_ept()', as already done in the remove function. > > Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to > rpmsg") It

[PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()'

2020-05-06 Thread Christophe JAILLET
In case of error, 'qcom_wcnss_open_channel()' must be undone by a call to 'rpmsg_destroy_ept()', as already done in the remove function. Fixes: 5052de8deff5 ("soc: qcom: smd: Transition client drivers from smd to rpmsg") Signed-off-by: Christophe JAILLET --- Not 100% sure of the commit for