Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread wyang1
On 09/06/2012 11:54 PM, Steven Rostedt wrote: On Thu, 2012-09-06 at 17:36 +0200, Robert Richter wrote: I meant: unsigned long kernel_stack_pointer(struct pt_regs *regs) { unsigned long context = (unsigned long)regs& ~(THREAD_SIZE - 1); unsigned long sp = (unsigned long)®s->sp;

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 17:36 +0200, Robert Richter wrote: > I meant: > > unsigned long kernel_stack_pointer(struct pt_regs *regs) > { > unsigned long context = (unsigned long)regs & ~(THREAD_SIZE - 1); > unsigned long sp = (unsigned long)®s->sp; > struct thread_info *tinfo; > >

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 11:14:42, Steven Rostedt wrote: > On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > > > --- a/arch/x86/oprofile/backtrace.c > > > > +++ b/arch/x86/oprofile/backtrace.c > > > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned > > > > int depth) > > >

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 17:34:07, Robert Richter wrote: > On 06.09.12 11:14:42, Steven Rostedt wrote: > > On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > > > > > --- a/arch/x86/oprofile/backtrace.c > > > > > +++ b/arch/x86/oprofile/backtrace.c > > > > > @@ -113,7 +113,7 @@ x86_backtrace(struct

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 17:02 +0200, Robert Richter wrote: > > > --- a/arch/x86/oprofile/backtrace.c > > > +++ b/arch/x86/oprofile/backtrace.c > > > @@ -113,7 +113,7 @@ x86_backtrace(struct pt_regs * const regs, unsigned > > > int depth) > > > > > > if (!user_mode_vm(regs)) { > > > un

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
On 06.09.12 09:14:42, Steven Rostedt wrote: > On Thu, 2012-09-06 at 12:04 +0200, Robert Richter wrote: > > > please take a look at this. Not sure if Linus want to look at this too > > and if we need more optimization here. > > It could probably go either way. Although the function has several > l

Re: [PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 12:04 +0200, Robert Richter wrote: > please take a look at this. Not sure if Linus want to look at this too > and if we need more optimization here. It could probably go either way. Although the function has several lines, it looks like the actual assembly produced wouldn't

[PATCH] x86, 32-bit: Fix invalid stack address while in softirq

2012-09-06 Thread Robert Richter
ngo, please take a look at this. Not sure if Linus want to look at this too and if we need more optimization here. Thanks, -Robert >From 8e7c16913b1fcfc63f7b24337551aacc7153c334 Mon Sep 17 00:00:00 2001 From: Robert Richter Date: Mon, 3 Sep 2012 20:54:48 +0200 Subject: [PATCH] x86, 32-bit: F