Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-26 Thread Borislav Petkov
On Thu, May 22, 2014 at 09:55:38PM +0200, Borislav Petkov wrote: > From: Borislav Petkov > Date: Thu, 22 May 2014 16:40:54 +0200 > Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD > > In conjunction with cleaning up CPU hotplug, we want to get rid of > CPU_POST_DEAD. Kill

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-26 Thread Borislav Petkov
On Thu, May 22, 2014 at 09:55:38PM +0200, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
et's keep it before more crap ensues, that was a good catch, thanks. > > So, I guess something like that instead. > > Which means, I'd need to run a couple of suspend/resume rounds while > hotplugging cores to see whether we're still kosher. > > More fun tomorrow. &

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
On 05/23/2014 03:01 AM, Borislav Petkov wrote: > On Fri, May 23, 2014 at 02:43:31AM +0530, Srivatsa S. Bhat wrote: After you move the cmci_rediscover() call, it is now in a place where we are no longer ignoring frozen (i.e. the old placement did the rediscover even if the

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
On Fri, May 23, 2014 at 02:43:31AM +0530, Srivatsa S. Bhat wrote: > >> After you move the cmci_rediscover() call, it is now in a place where we > >> are > >> no longer ignoring frozen (i.e. the old placement did the rediscover even > >> if the > >> CPU_TASKS_FROZEN bit was set - with the new

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
mething like that instead. > > Which means, I'd need to run a couple of suspend/resume rounds while > hotplugging cores to see whether we're still kosher. > > More fun tomorrow. > > --- > From: Borislav Petkov > Date: Thu, 22 May 2014 16:40:54 +0200 > Subject: [PATCH] x

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
suspend/resume rounds while hotplugging cores to see whether we're still kosher. More fun tomorrow. --- From: Borislav Petkov Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD

RE: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Luck, Tony
>> So I think we can reduce it to just the one rwsem (with recursion) if we >> shoot CPU_POST_DEAD in the head. > > Here's the first bullet. Stressing my box here with Steve's hotplug > script seems to work fine. > > Tony, any objections? what was this comment referring to: /* intentionally

[PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
ctions? --- From: Borislav Petkov Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here and rediscover CMCI banks at the end of CPU_DEAD. Signed-off-by: Borislav

[PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
? --- From: Borislav Petkov b...@suse.de Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here and rediscover CMCI banks at the end of CPU_DEAD. Signed-off-by: Borislav

RE: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Luck, Tony
So I think we can reduce it to just the one rwsem (with recursion) if we shoot CPU_POST_DEAD in the head. Here's the first bullet. Stressing my box here with Steve's hotplug script seems to work fine. Tony, any objections? what was this comment referring to: /* intentionally ignoring

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
: Borislav Petkov b...@suse.de Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here and rediscover CMCI banks at the end of CPU_DEAD. Signed-off-by: Borislav Petkov b

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here and rediscover CMCI banks at the end of CPU_DEAD. Signed-off-by: Borislav Petkov b...@suse.de --- arch/x86/kernel/cpu/mcheck

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Borislav Petkov
On Fri, May 23, 2014 at 02:43:31AM +0530, Srivatsa S. Bhat wrote: After you move the cmci_rediscover() call, it is now in a place where we are no longer ignoring frozen (i.e. the old placement did the rediscover even if the CPU_TASKS_FROZEN bit was set - with the new placement we will

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
On 05/23/2014 03:01 AM, Borislav Petkov wrote: On Fri, May 23, 2014 at 02:43:31AM +0530, Srivatsa S. Bhat wrote: After you move the cmci_rediscover() call, it is now in a place where we are no longer ignoring frozen (i.e. the old placement did the rediscover even if the CPU_TASKS_FROZEN

Re: [PATCH] x86, MCE: Kill CPU_POST_DEAD

2014-05-22 Thread Srivatsa S. Bhat
still kosher. More fun tomorrow. --- From: Borislav Petkov b...@suse.de Date: Thu, 22 May 2014 16:40:54 +0200 Subject: [PATCH] x86, MCE: Kill CPU_POST_DEAD In conjunction with cleaning up CPU hotplug, we want to get rid of CPU_POST_DEAD. Kill this instance here and rediscover CMCI