On 25/04/13 11:47, Borislav Petkov wrote:
> I wonder - if efi_runtime_service_t contained only void * like
> efi_boot_services_t then we could drop all the casts too, right? Even in
> the efi_call* macro calls too...
Yeah, that's what I figured.
> If you want me, I can take care of it after the
On Thu, Apr 25, 2013 at 08:19:05AM +0100, Matt Fleming wrote:
> Yeah, I'm not advocating using casts, I was just saying "Oh, x86-64
> avoids requiring the caller of efi_call_phys* to perform the cast
> by doing it in the definition of efi_call*. That's why this is only
> affecting 32-bit."
>
>
* Matt Fleming wrote:
> On 25/04/13 07:55, Ingo Molnar wrote:
> > It's a basic cleanliness and robustness issue: we generally avoid type
> > casts in the kernel, because type casts override compile-time type checks
> > and are easy to get wrong. They are also ugly.
> >
> > So in generaly we
On 25/04/13 07:55, Ingo Molnar wrote:
> It's a basic cleanliness and robustness issue: we generally avoid type
> casts in the kernel, because type casts override compile-time type checks
> and are easy to get wrong. They are also ugly.
>
> So in generaly we try to use the right type for the
* Matt Fleming wrote:
> On 24/04/13 11:56, Ingo Molnar wrote:
> >
> > * Borislav Petkov wrote:
> >
> >> From: Borislav Petkov
> >>
> >> Fix this:
> >>
> >> arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
> >> arch/x86/boot/compressed/eboot.c:269:2: warning: passing
* Matt Fleming matt.flem...@intel.com wrote:
On 24/04/13 11:56, Ingo Molnar wrote:
* Borislav Petkov b...@alien8.de wrote:
From: Borislav Petkov b...@suse.de
Fix this:
arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
arch/x86/boot/compressed/eboot.c:269:2:
On 25/04/13 07:55, Ingo Molnar wrote:
It's a basic cleanliness and robustness issue: we generally avoid type
casts in the kernel, because type casts override compile-time type checks
and are easy to get wrong. They are also ugly.
So in generaly we try to use the right type for the data
* Matt Fleming matt.flem...@intel.com wrote:
On 25/04/13 07:55, Ingo Molnar wrote:
It's a basic cleanliness and robustness issue: we generally avoid type
casts in the kernel, because type casts override compile-time type checks
and are easy to get wrong. They are also ugly.
So in
On Thu, Apr 25, 2013 at 08:19:05AM +0100, Matt Fleming wrote:
Yeah, I'm not advocating using casts, I was just saying Oh, x86-64
avoids requiring the caller of efi_call_phys* to perform the cast
by doing it in the definition of efi_call*. That's why this is only
affecting 32-bit.
Cleaning
On 25/04/13 11:47, Borislav Petkov wrote:
I wonder - if efi_runtime_service_t contained only void * like
efi_boot_services_t then we could drop all the casts too, right? Even in
the efi_call* macro calls too...
Yeah, that's what I figured.
If you want me, I can take care of it after the
On Wed, Apr 24, 2013 at 12:17:59PM +0100, Matt Fleming wrote:
> We could either change all fields in efi_system_table or the
> efi_call_phys* prototypes. x86-64 already casts to (void *) when
> calling efi_call0(), etc, though I'm not entirely sure why void * is
> needed.
Well, sizeof(void *) ==
On 24/04/13 11:56, Ingo Molnar wrote:
>
> * Borislav Petkov wrote:
>
>> From: Borislav Petkov
>>
>> Fix this:
>>
>> arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
>> arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
>> ???efi_call_phys??? makes
* Borislav Petkov wrote:
> From: Borislav Petkov
>
> Fix this:
>
> arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
> arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
> ???efi_call_phys??? makes pointer from integer without a cast [enabled by
>
On 24/04/13 11:09, Borislav Petkov wrote:
> From: Borislav Petkov
>
> Fix this:
>
> arch/x86/boot/compressed/eboot.c: In function ‘setup_efi_vars’:
> arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
> ‘efi_call_phys’ makes pointer from integer without a cast [enabled by
From: Borislav Petkov
Fix this:
arch/x86/boot/compressed/eboot.c: In function ‘setup_efi_vars’:
arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
‘efi_call_phys’ makes pointer from integer without a cast [enabled by default]
In file included from
From: Borislav Petkov b...@suse.de
Fix this:
arch/x86/boot/compressed/eboot.c: In function ‘setup_efi_vars’:
arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
‘efi_call_phys’ makes pointer from integer without a cast [enabled by default]
In file included from
On 24/04/13 11:09, Borislav Petkov wrote:
From: Borislav Petkov b...@suse.de
Fix this:
arch/x86/boot/compressed/eboot.c: In function ‘setup_efi_vars’:
arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
‘efi_call_phys’ makes pointer from integer without a cast [enabled
* Borislav Petkov b...@alien8.de wrote:
From: Borislav Petkov b...@suse.de
Fix this:
arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
???efi_call_phys??? makes pointer from integer without a cast
On 24/04/13 11:56, Ingo Molnar wrote:
* Borislav Petkov b...@alien8.de wrote:
From: Borislav Petkov b...@suse.de
Fix this:
arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???:
arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of
???efi_call_phys???
On Wed, Apr 24, 2013 at 12:17:59PM +0100, Matt Fleming wrote:
We could either change all fields in efi_system_table or the
efi_call_phys* prototypes. x86-64 already casts to (void *) when
calling efi_call0(), etc, though I'm not entirely sure why void * is
needed.
Well, sizeof(void *) ==
20 matches
Mail list logo
