Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-18 Thread Yu Chen
Hi! On 08/18/2015 04:02 PM, Pavel Machek wrote: Hi! A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( Might need to register for accessing. What HW is this on? Intel Braswell and Broadwell, detail for Broadwell: Platform: MayanCity Processor: 2x

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-18 Thread Pavel Machek
Hi! > >>>A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > > > >Access denied :-( > > > Might need to register for accessing. > > > >What HW is this on? > > > Intel Braswell and Broadwell, detail for Broadwell: > Platform: MayanCity > Processor: 2x BROADWELL BDX_EP A0 QHPR

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-18 Thread Yu Chen
Hi! On 08/18/2015 04:02 PM, Pavel Machek wrote: Hi! A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( Might need to register for accessing. What HW is this on? Intel Braswell and Broadwell, detail for Broadwell: Platform: MayanCity Processor: 2x

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-18 Thread Pavel Machek
Hi! A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( Might need to register for accessing. What HW is this on? Intel Braswell and Broadwell, detail for Broadwell: Platform: MayanCity Processor: 2x BROADWELL BDX_EP A0 QHPR Chipset: Wellsburg

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Yu Chen
Hi Pavel, thanks for your review, On 08/17/2015 09:27 PM, Pavel Machek wrote: On Mon 2015-08-17 12:11:15, Ingo Molnar wrote: * Chen Yu wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( Might need to register for accessing. What HW is this

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Yu Chen
(not sure if previous reply has been sent out) Hi, Ingo, thanks for your review, On 08/17/2015 06:11 PM, Ingo Molnar wrote: * Chen Yu wrote: So what your changelog fails to mention: - You only add this code to the 64-bit kernel. Are 32-bit kernels not affected? I missed the 32-bit

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Pavel Machek
On Mon 2015-08-17 12:11:15, Ingo Molnar wrote: > > * Chen Yu wrote: > > > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( > > that, after resuming from S3, CPU is working at a low speed. > > After investigation, it is found that, BIOS has modified the

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Chen, Yu C
Hi, Ingo, thanks for your review, On Mon, 2015-08-17 at 12:11 +0200, Ingo Molnar wrote: > So what your changelog fails to mention: > > - You only add this code to the 64-bit kernel. Are 32-bit kernels not > affected? Yes, 32-bit kernel should also do the save/restore operation. I'll adjust

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Ingo Molnar
* Chen Yu wrote: > A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) > that, after resuming from S3, CPU is working at a low speed. > After investigation, it is found that, BIOS has modified the value > of THERM_CONTROL register during S3, changes it from 0 to 0x10, > while

[PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Chen Yu
A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from 0 to 0x10, while the latter means CPU can only

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Ingo Molnar
* Chen Yu yu.c.c...@intel.com wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from 0

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Chen, Yu C
Hi, Ingo, thanks for your review, On Mon, 2015-08-17 at 12:11 +0200, Ingo Molnar wrote: So what your changelog fails to mention: - You only add this code to the 64-bit kernel. Are 32-bit kernels not affected? Yes, 32-bit kernel should also do the save/restore operation. I'll adjust them to

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Yu Chen
(not sure if previous reply has been sent out) Hi, Ingo, thanks for your review, On 08/17/2015 06:11 PM, Ingo Molnar wrote: * Chen Yu yu.c.c...@intel.com wrote: So what your changelog fails to mention: - You only add this code to the 64-bit kernel. Are 32-bit kernels not affected? I

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Yu Chen
Hi Pavel, thanks for your review, On 08/17/2015 09:27 PM, Pavel Machek wrote: On Mon 2015-08-17 12:11:15, Ingo Molnar wrote: * Chen Yu yu.c.c...@intel.com wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( Might need to register for accessing.

Re: [PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Pavel Machek
On Mon 2015-08-17 12:11:15, Ingo Molnar wrote: * Chen Yu yu.c.c...@intel.com wrote: A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) Access denied :-( that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has

[PATCH] x86, suspend: Save/restore THERM_CONTROL register for suspend

2015-08-17 Thread Chen Yu
A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resuming from S3, CPU is working at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, changes it from 0 to 0x10, while the latter means CPU can only