RE: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-24 Thread Ghannam, Yazen
ATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on > AMD systems > > On Wed 2017-05-17 09:20:19, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > AMD systems support the Monitor/Mwait instructions and these can be > > used for ACPI C1 in the same way

Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-23 Thread Borislav Petkov
On Tue, May 23, 2017 at 12:50:15PM +, Ghannam, Yazen wrote: > No, AMD systems will continue to use HLT unless the BIOS specifies the > use of MWAIT using a FFH entry in the ACPI _CST. > > All this change does is *allow* us to use MWAIT through the FFH > implementation if the BIOS defines it. I

RE: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-23 Thread Ghannam, Yazen
> Subject: Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on > AMD systems > > On Mon, May 22, 2017 at 08:20:56PM +, Ghannam, Yazen wrote: > > On the other hand, MWAIT on AMD limits the hardware to using only > > certain, shallower Cstates. This is okay if we d

Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-23 Thread Pavel Machek
On Wed 2017-05-17 09:20:19, Yazen Ghannam wrote: > From: Yazen Ghannam > > AMD systems support the Monitor/Mwait instructions and these can be used > for ACPI C1 in the same way as on Intel systems, with appropriate BIOS > support. > > Allow ffh_cstate_init() to succeed on AMD systems and make t

Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-23 Thread Borislav Petkov
On Mon, May 22, 2017 at 08:20:56PM +, Ghannam, Yazen wrote: > On the other hand, MWAIT on AMD limits the hardware to using only certain, > shallower Cstates. This is okay if we define individual states and use MWAIT > for some of them. But it would consume more power if used always. Let me see

RE: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-22 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, May 22, 2017 12:22 PM > ... > What about x86_idle? > > That whole select_idle_routine() jumping through hoops. That's still doing > default_idle() on Zen, AFAICT. > > Or am I missing something? > > Be

Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-22 Thread Borislav Petkov
On Wed, May 17, 2017 at 09:20:19AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > AMD systems support the Monitor/Mwait instructions and these can be used > for ACPI C1 in the same way as on Intel systems, with appropriate BIOS > support. > > Allow ffh_cstate_init() to succeed on AMD syst

[PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems

2017-05-17 Thread Yazen Ghannam
From: Yazen Ghannam AMD systems support the Monitor/Mwait instructions and these can be used for ACPI C1 in the same way as on Intel systems, with appropriate BIOS support. Allow ffh_cstate_init() to succeed on AMD systems and make the Cstate description vendor-agnostic. Signed-off-by: Yazen Gh