Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS

2017-12-30 Thread sonofagun
Hello Borris, thank you both. It was about time... Thanks for your effort though! Ingo is right here any modification must be advertised. The patch was sent on October but I didn't fell on it until... yesterday when I saw that it was routed for 3.16! [3.16,136/204] x86/cpu/AMD: Apply the

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS

2017-12-30 Thread sonofagun
Hello Borris, thank you both. It was about time... Thanks for your effort though! Ingo is right here any modification must be advertised. The patch was sent on October but I didn't fell on it until... yesterday when I saw that it was routed for 3.16! [3.16,136/204] x86/cpu/AMD: Apply the

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Ingo Molnar
* Borislav Petkov wrote: > On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > > Any objections to me adding a printk message that we applied a fix? > > > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > > > or so? > > > > That would also create

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Ingo Molnar
* Borislav Petkov wrote: > On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > > Any objections to me adding a printk message that we applied a fix? > > > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > > > or so? > > > > That would also create some pressure for

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Borislav Petkov
On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > Any objections to me adding a printk message that we applied a fix? > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > or so? > > That would also create some pressure for customers to prod manufacturers to >

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Borislav Petkov
On Sun, Oct 22, 2017 at 01:04:38PM +0200, Ingo Molnar wrote: > Any objections to me adding a printk message that we applied a fix? > > pr_info("x86/cpu/AMD: CPU erratum 688 worked around\n"); > > or so? > > That would also create some pressure for customers to prod manufacturers to >

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Borislav Petkov > > Some F14h machines have an erratum which, "under a highly specific > and detailed set of internal timing conditions" can lead to skipping > instructions and rIP corruption. Add the fix for those machines when >

Re: [PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Ingo Molnar
* Borislav Petkov wrote: > From: Borislav Petkov > > Some F14h machines have an erratum which, "under a highly specific > and detailed set of internal timing conditions" can lead to skipping > instructions and rIP corruption. Add the fix for those machines when > their BIOS doesn't apply it

[PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Borislav Petkov
From: Borislav Petkov Some F14h machines have an erratum which, "under a highly specific and detailed set of internal timing conditions" can lead to skipping instructions and rIP corruption. Add the fix for those machines when their BIOS doesn't apply it or there simply isn't BIOS

[PATCH] x86/AMD: Apply Erratum 688 fix when BIOS doesn't

2017-10-22 Thread Borislav Petkov
From: Borislav Petkov Some F14h machines have an erratum which, "under a highly specific and detailed set of internal timing conditions" can lead to skipping instructions and rIP corruption. Add the fix for those machines when their BIOS doesn't apply it or there simply isn't BIOS update for