Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Mon, Jun 18, 2018 at 01:46:11PM -0500, Suthikulpanit, Suravee wrote: > Your understanding is correct. I was not sure about what you were referring > to earlier. Basically, the number of threads sharing cache is used to > calculate the amount of right-shifting of APIC ID, which results in

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Mon, Jun 18, 2018 at 01:46:11PM -0500, Suthikulpanit, Suravee wrote: > Your understanding is correct. I was not sure about what you were referring > to earlier. Basically, the number of threads sharing cache is used to > calculate the amount of right-shifting of APIC ID, which results in

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Suthikulpanit, Suravee
Boris, On 6/18/2018 1:23 PM, Borislav Petkov wrote: On Mon, Jun 18, 2018 at 01:14:11PM -0500, Suthikulpanit, Suravee wrote: This enumeration is only for the family17h model 00-1Fh of hardware revision. The patch is intended for the future revision of hardware. I realized that but the same

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Suthikulpanit, Suravee
Boris, On 6/18/2018 1:23 PM, Borislav Petkov wrote: On Mon, Jun 18, 2018 at 01:14:11PM -0500, Suthikulpanit, Suravee wrote: This enumeration is only for the family17h model 00-1Fh of hardware revision. The patch is intended for the future revision of hardware. I realized that but the same

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Mon, Jun 18, 2018 at 01:14:11PM -0500, Suthikulpanit, Suravee wrote: > This enumeration is only for the family17h model 00-1Fh of hardware > revision. The patch is intended for the future revision of hardware. I realized that but the same holds true for the future revision - there you need to

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Mon, Jun 18, 2018 at 01:14:11PM -0500, Suthikulpanit, Suravee wrote: > This enumeration is only for the family17h model 00-1Fh of hardware > revision. The patch is intended for the future revision of hardware. I realized that but the same holds true for the future revision - there you need to

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Suthikulpanit, Suravee
Boris, On 6/18/2018 12:20 PM, Borislav Petkov wrote: On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote: The current logic incorrectly calculates the LLC ID from the APIC ID. Unless specified otherwise, the LLC ID should be calculated from the count order of the number of

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Suthikulpanit, Suravee
Boris, On 6/18/2018 12:20 PM, Borislav Petkov wrote: On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote: The current logic incorrectly calculates the LLC ID from the APIC ID. Unless specified otherwise, the LLC ID should be calculated from the count order of the number of

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote: > The current logic incorrectly calculates the LLC ID from the APIC ID. > Unless specified otherwise, the LLC ID should be calculated from > the count order of the number of threads sharing cache. Don't you mean: "... should

Re: [PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-18 Thread Borislav Petkov
On Wed, Jun 13, 2018 at 01:43:10PM -0500, Suravee Suthikulpanit wrote: > The current logic incorrectly calculates the LLC ID from the APIC ID. > Unless specified otherwise, the LLC ID should be calculated from > the count order of the number of threads sharing cache. Don't you mean: "... should

[PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-13 Thread Suravee Suthikulpanit
The current logic incorrectly calculates the LLC ID from the APIC ID. Unless specified otherwise, the LLC ID should be calculated from the count order of the number of threads sharing cache. Fixes: 68091ee7ac3c ("Calculate last level cache ID from number of sharing threads") Signed-off-by:

[PATCH] x86/CPU/AMD: Fix LLC ID bit-shift calculation

2018-06-13 Thread Suravee Suthikulpanit
The current logic incorrectly calculates the LLC ID from the APIC ID. Unless specified otherwise, the LLC ID should be calculated from the count order of the number of threads sharing cache. Fixes: 68091ee7ac3c ("Calculate last level cache ID from number of sharing threads") Signed-off-by: