Re: [PATCH] x86/asm: add __user on copy_user_handle_tail() pointers

2019-03-28 Thread Borislav Petkov
On Thu, Mar 28, 2019 at 08:48:33AM -0700, Linus Torvalds wrote: > Well, it does that because the x86 version of copy_user_generic() can > work in either direction, so it works when either the source or > destination (or both) are user pointers, but they don't _have_ to be. > > So the "userness"

Re: [PATCH] x86/asm: add __user on copy_user_handle_tail() pointers

2019-03-28 Thread Linus Torvalds
On Thu, Mar 28, 2019 at 12:24 AM Borislav Petkov wrote: > > Well, but copy_user_generic() (which ends up calling the > copy_user_handle_tail() eventually) casts those __user pointers to > (__force void *). Converting them back to __user looks strange to me. > > Linus? Well, it does that because

Re: [PATCH] x86/asm: add __user on copy_user_handle_tail() pointers

2019-03-28 Thread Borislav Petkov
On Thu, Feb 28, 2019 at 06:50:27PM +, Ben Dooks wrote: > The copy_user_handle_tail() clearly uses both from and to as pointers > to user-space memory. This triggers sparse warning on using the calls > to get and put to user-space. This can be fixed easily by changing the > call to take __user

[PATCH] x86/asm: add __user on copy_user_handle_tail() pointers

2019-02-28 Thread Ben Dooks
The copy_user_handle_tail() clearly uses both from and to as pointers to user-space memory. This triggers sparse warning on using the calls to get and put to user-space. This can be fixed easily by changing the call to take __user annotated pointer.s arch/x86/lib/usercopy_64.c:68:21: warning: