Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-10 Thread Cao jin
On 1/8/19 4:46 PM, Cao jin wrote: > One more question: in compressed/, for mem*(), it seems we both use the > macros of boot/string.h, and the functions of compressed/string.c. Is > that what we want? > > compressed/ is compiled with -O2, so it cannot be told by objdump -d, > but still can be

Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-10 Thread Cao jin
Hello HPA, On 1/8/19 4:38 PM, h...@zytor.com wrote: > On January 7, 2019 12:52:57 AM PST, Cao jin wrote: >> Hi, >> >> On 1/7/19 3:59 PM, h...@zytor.com wrote: >>> On January 6, 2019 11:40:56 PM PST, Cao jin >> wrote: According to objdump output of setup, function memset is not used in

Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-08 Thread Cao jin
One more question: in compressed/, for mem*(), it seems we both use the macros of boot/string.h, and the functions of compressed/string.c. Is that what we want? compressed/ is compiled with -O2, so it cannot be told by objdump -d, but still can be confirmed by nm <*.o>, for example: $nm

Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-08 Thread hpa
On January 7, 2019 12:52:57 AM PST, Cao jin wrote: >Hi, > >On 1/7/19 3:59 PM, h...@zytor.com wrote: >> On January 6, 2019 11:40:56 PM PST, Cao jin > wrote: >>> According to objdump output of setup, function memset is not used in >>> setup code. Currently, all usage of memset in setup come from

Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-07 Thread Cao jin
Hi, On 1/7/19 3:59 PM, h...@zytor.com wrote: > On January 6, 2019 11:40:56 PM PST, Cao jin wrote: >> According to objdump output of setup, function memset is not used in >> setup code. Currently, all usage of memset in setup come from macro >> definition of string.h. >> >> Signed-off-by: Cao jin

Re: [PATCH] x86/boot: drop memset from copy.S

2019-01-07 Thread hpa
On January 6, 2019 11:40:56 PM PST, Cao jin wrote: >According to objdump output of setup, function memset is not used in >setup code. Currently, all usage of memset in setup come from macro >definition of string.h. > >Signed-off-by: Cao jin >--- >Compiled and booted under x86_64; compiled under

[PATCH] x86/boot: drop memset from copy.S

2019-01-06 Thread Cao jin
According to objdump output of setup, function memset is not used in setup code. Currently, all usage of memset in setup come from macro definition of string.h. Signed-off-by: Cao jin --- Compiled and booted under x86_64; compiled under i386. Questions: now there is 2 definition of memcpy, one