Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro

2019-08-28 Thread Cao jin
On 8/28/19 2:42 PM, Borislav Petkov wrote: > On Wed, Aug 28, 2019 at 02:11:00PM +0800, Cao jin wrote: > > For the future: > >> Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro > > your subject needs to have a verb and start with a capital lett

Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro

2019-08-28 Thread Borislav Petkov
On Wed, Aug 28, 2019 at 02:11:00PM +0800, Cao jin wrote: For the future: > Subject: Re: [PATCH] x86/cpufeature: explicit comments for duplicate macro your subject needs to have a verb and start with a capital letter after the subsystem/path prefix. In this case, something like this, for exam

[PATCH] x86/cpufeature: explicit comments for duplicate macro

2019-08-28 Thread Cao jin
Help people to understand the author's intent of apparent duplication of BUILD_BUG_ON_ZERO(NCAPINTS != n), which is hard to detect by eyes. CC: Dave Hansen Suggested-by: Borislav Petkov Signed-off-by: Cao jin --- Tried my best to describe it accurately, in case of any inaccuracy, feel free to