RE: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-28 Thread Prakhya, Sai Praneeth
> > Acked-by: Ard Biesheuvel > > > > with the sidenote that I won't be able to test this myself until > > monday at the earliest. > > OK, so I have tested both efi=old_map and mixed mode before and after > applying this patch, using QEMU/KVM with 64-bit and 32-bit builds of OVMF > [respectively]

Re: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-25 Thread Ingo Molnar
* Prakhya, Sai Praneeth wrote: > > > > + /* > > > > + * To Do: Remove this check after adding functionality to unmap > > > > EFI > > boot > > > > + * services code/data regions from direct mapping area because > > > > + * "efi=old_map" maps EFI regions in swapper_pg_dir. >

Re: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-24 Thread Ard Biesheuvel
On Sat, 22 Dec 2018 at 12:04, Ard Biesheuvel wrote: > > On Sat, 22 Dec 2018 at 11:54, Ingo Molnar wrote: > > > > > > * Sai Praneeth Prakhya wrote: > > > > > Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions > > > from efi_pgd") forgets to take two EFI modes into

RE: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-22 Thread Prakhya, Sai Praneeth
> > * Sai Praneeth Prakhya wrote: > > > Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data > > regions from efi_pgd") forgets to take two EFI modes into > > consideration namely EFI_OLD_MEMMAP and EFI_MIXED_MODE. > > So the commit sha1 ended up being this one in tip:efi/core: >

Re: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-22 Thread Ingo Molnar
* Sai Praneeth Prakhya wrote: > Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions > from efi_pgd") forgets to take two EFI modes into consideration namely > EFI_OLD_MEMMAP and EFI_MIXED_MODE. So the commit sha1 ended up being this one in tip:efi/core: 08cfb38f3ef4:

Re: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-22 Thread Ard Biesheuvel
On Sat, 22 Dec 2018 at 11:54, Ingo Molnar wrote: > > > * Sai Praneeth Prakhya wrote: > > > Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions > > from efi_pgd") forgets to take two EFI modes into consideration namely > > EFI_OLD_MEMMAP and EFI_MIXED_MODE. > > So the commit

[PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-21 Thread Sai Praneeth Prakhya
Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data regions from efi_pgd") forgets to take two EFI modes into consideration namely EFI_OLD_MEMMAP and EFI_MIXED_MODE. EFI_OLD_MEMMAP is a legacy way of mapping EFI regions into swapper_pg_dir using ioremap() and init_memory_mapping().