Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof

2021-01-21 Thread Yejune Deng
Thank you for your suggestion! On Wed, Jan 20, 2021 at 6:22 PM Borislav Petkov wrote: > > On Wed, Jan 20, 2021 at 02:44:15PM +0800, Yejune Deng wrote: > > In fpstate_sanitize_xstate(), use memset and offsetof instead of '= 0', > > and use sizeof instead of a constant. > > > > Signed-off-by: Yejun

Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof

2021-01-20 Thread Borislav Petkov
On Wed, Jan 20, 2021 at 02:44:15PM +0800, Yejune Deng wrote: > In fpstate_sanitize_xstate(), use memset and offsetof instead of '= 0', > and use sizeof instead of a constant. > > Signed-off-by: Yejune Deng > --- > arch/x86/kernel/fpu/xstate.c | 10 +++--- > 1 file changed, 3 insertions(+), 7

Re: [PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof

2021-01-19 Thread Dave Hansen
On 1/19/21 10:44 PM, Yejune Deng wrote: > In fpstate_sanitize_xstate(), use memset and offsetof instead of '= 0', > and use sizeof instead of a constant. What's the benefit to doing this? Saving 4 lines of code? Your suggestions are not obviously wrong at a glance, but they're also not obviously

[PATCH] x86/fpu/xstate: calculate the number by sizeof and offsetof

2021-01-19 Thread Yejune Deng
In fpstate_sanitize_xstate(), use memset and offsetof instead of '= 0', and use sizeof instead of a constant. Signed-off-by: Yejune Deng --- arch/x86/kernel/fpu/xstate.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/