Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-16 Thread Dou Liyang
Hi Arnd, At 01/16/2018 04:50 PM, Arnd Bergmann wrote: On Tue, Jan 16, 2018 at 9:17 AM, Dou Liyang wrote: Hi Arnd, [...] The reason I don't want to expose the x2apic_mode and x2apic_phys is that they may be misused in X2APIC=n case. So I create an interface to wrap it. do you think so? ;-)

Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 9:17 AM, Dou Liyang wrote: > Hi Arnd, > > [...] >>> >>> The reason I don't want to expose the x2apic_mode and x2apic_phys is >>> that they may be misused in X2APIC=n case. So I create an interface to >>> wrap it. do you think so? ;-) >> >> >> I'm not sure I follow what the

Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-16 Thread Dou Liyang
Hi Arnd, [...] The reason I don't want to expose the x2apic_mode and x2apic_phys is that they may be misused in X2APIC=n case. So I create an interface to wrap it. do you think so? ;-) I'm not sure I follow what the intention of that is. If you want to hide My purpose of that is hiding the v

Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-15 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 3:34 AM, Dou Liyang wrote: > At 01/16/2018 09:25 AM, Dou Liyang wrote: >>> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h >>> index 98722773391d..0317d635d9ba 100644 >>> --- a/arch/x86/include/asm/apic.h >>> +++ b/arch/x86/include/asm/apic.h >>> @@

Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-15 Thread Dou Liyang
Hi Arnd, At 01/16/2018 09:25 AM, Dou Liyang wrote: Hi Arnd, At 01/16/2018 04:23 AM, Arnd Bergmann wrote: When CONFIG_X86_X2APIC is disabled, jailhouse fails to build: arch/x86/kernel/jailhouse.c: In function 'jailhouse_get_smp_config': arch/x86/kernel/jailhouse.c:73:3: error: 'x2apic_phys' un

Re: [PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-15 Thread Dou Liyang
Hi Arnd, At 01/16/2018 04:23 AM, Arnd Bergmann wrote: When CONFIG_X86_X2APIC is disabled, jailhouse fails to build: arch/x86/kernel/jailhouse.c: In function 'jailhouse_get_smp_config': arch/x86/kernel/jailhouse.c:73:3: error: 'x2apic_phys' undeclared (first use in this function); did you mean

[PATCH] x86/jailhouse: fix building without X86_X2APIC

2018-01-15 Thread Arnd Bergmann
When CONFIG_X86_X2APIC is disabled, jailhouse fails to build: arch/x86/kernel/jailhouse.c: In function 'jailhouse_get_smp_config': arch/x86/kernel/jailhouse.c:73:3: error: 'x2apic_phys' undeclared (first use in this function); did you mean 'x2apic_mode'? The code is protected by an appropriate x