Re: [pet...@infradead.org: Re: [PATCH] x86/kgdb: Allow removal of early BPs]

2021-02-17 Thread Sumit Garg
Hi Peter, > On Mon, Dec 14, 2020 at 03:13:12PM +0100, Stefan Saecherl wrote: > > > One thing to consider when doing this is that code can go away during boot > > (e.g. .init.text). Previously kgdb_arch_remove_breakpoint handled this case > > gracefully by just having copy_to_kernel_nofault fail

Re: [PATCH] x86/kgdb: Allow removal of early BPs

2021-01-27 Thread Borislav Petkov
On Tue, Jan 26, 2021 at 12:39:17PM +0100, Peter Zijlstra wrote: > On Mon, Dec 14, 2020 at 03:13:12PM +0100, Stefan Saecherl wrote: > > > One thing to consider when doing this is that code can go away during boot > > (e.g. .init.text). Previously kgdb_arch_remove_breakpoint handled this case > >

Re: [PATCH] x86/kgdb: Allow removal of early BPs

2021-01-26 Thread Peter Zijlstra
On Mon, Dec 14, 2020 at 03:13:12PM +0100, Stefan Saecherl wrote: > One thing to consider when doing this is that code can go away during boot > (e.g. .init.text). Previously kgdb_arch_remove_breakpoint handled this case > gracefully by just having copy_to_kernel_nofault fail but if one then calls

Re: [PATCH] x86/kgdb: Allow removal of early BPs

2021-01-25 Thread Lorena Kretzschmar
Hi, I wanted to ask about the status of the patch. Let us know if there are any other steps we can undertake. Kind regards Lorena On Fri 2020-12-18 16:44:21, Daniel Thompson wrote: > Hi Stefan > > On Mon, Dec 14, 2020 at 03:13:12PM +0100, Stefan Saecherl wrote: > > The problem is that

Re: [PATCH] x86/kgdb: Allow removal of early BPs

2020-12-18 Thread Daniel Thompson
Hi Stefan On Mon, Dec 14, 2020 at 03:13:12PM +0100, Stefan Saecherl wrote: > The problem is that breakpoints that are set early (e.g. via kgdbwait) > cannot be deleted after boot completed (to be precise after mark_rodata_ro > ran). > > When setting a breakpoint early there are executable pages

[PATCH] x86/kgdb: Allow removal of early BPs

2020-12-14 Thread Stefan Saecherl
The problem is that breakpoints that are set early (e.g. via kgdbwait) cannot be deleted after boot completed (to be precise after mark_rodata_ro ran). When setting a breakpoint early there are executable pages that are writable so the copy_to_kernel_nofault call in kgdb_arch_set_breakpoint