RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-21 Thread Ghannam, Yazen
rnel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > > Just forget the work scheduling - it is only a marginal implementation thing - > you only want to say that we want to log the severity since we already have > it. > And the most impor

RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-21 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, June 19, 2017 12:49 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; Tony Luck ; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce:

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-19 Thread Borislav Petkov
On Fri, Jun 16, 2017 at 02:49:58PM +, Ghannam, Yazen wrote: > The code block being removed here was added in the following commit to decide > whether or not to schedule work. > > fa92c58 x86, mce: Support memory error recovery for both UCNA and Deferred > error in machine_check_poll Are you

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-19 Thread Borislav Petkov
On Fri, Jun 16, 2017 at 02:49:58PM +, Ghannam, Yazen wrote: > The code block being removed here was added in the following commit to decide > whether or not to schedule work. > > fa92c58 x86, mce: Support memory error recovery for both UCNA and Deferred > error in machine_check_poll Are you

RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-16 Thread Ghannam, Yazen
l.org; Tony Luck <tony.l...@intel.com>; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > > From: Yazen Ghannam <yazen.ghan...@amd.com&g

RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-16 Thread Ghannam, Yazen
nel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > Remove code that was used to decide whether to schedule work. T

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-14 Thread Borislav Petkov
On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > Remove code that was used to decide whether to schedule work. The decision ??? I'm missing a *lot* of background in order to understand what that sentence means. -- Regards/Gruss,

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-14 Thread Borislav Petkov
On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > Remove code that was used to decide whether to schedule work. The decision ??? I'm missing a *lot* of background in order to understand what that sentence means. -- Regards/Gruss, Boris. Good

RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Ghannam, Yazen
tkov <b...@suse.de>; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > > - severity = mce_severity(, mca_cfg.tolerant,

RE: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Ghannam, Yazen
ernel@vger.kernel.org > Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll > > On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > > - severity = mce_severity(, mca_cfg.tolerant, NULL, false); > > - > > -

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Luck, Tony
On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > - severity = mce_severity(, mca_cfg.tolerant, NULL, false); > - > - if (severity == MCE_DEFERRED_SEVERITY && > mce_is_memory_error()) > - if (m.status & MCI_STATUS_ADDRV) > -

Re: [PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Luck, Tony
On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote: > - severity = mce_severity(, mca_cfg.tolerant, NULL, false); > - > - if (severity == MCE_DEFERRED_SEVERITY && > mce_is_memory_error()) > - if (m.status & MCI_STATUS_ADDRV) > -

[PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Yazen Ghannam
From: Yazen Ghannam Remove code that was used to decide whether to schedule work. The decision to schedule work is made later, so this code is now only deciding if we should save the error severity. Save the severity since we have it, and let the notifier blocks decide if

[PATCH] x86/mce: Always save severity in machine_check_poll

2017-06-12 Thread Yazen Ghannam
From: Yazen Ghannam Remove code that was used to decide whether to schedule work. The decision to schedule work is made later, so this code is now only deciding if we should save the error severity. Save the severity since we have it, and let the notifier blocks decide if they want to do