RE: [PATCH] x86/mce: Handle varying MCA bank counts

2018-08-01 Thread Ghannam, Yazen
> -Original Message- > From: Luck, Tony > Sent: Friday, July 27, 2018 5:09 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; b...@suse.de; > x...@kernel.org > Subject: Re: [PATCH] x86/mce: Handle varying MCA bank counts >

RE: [PATCH] x86/mce: Handle varying MCA bank counts

2018-08-01 Thread Ghannam, Yazen
> -Original Message- > From: Luck, Tony > Sent: Friday, July 27, 2018 5:09 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; b...@suse.de; > x...@kernel.org > Subject: Re: [PATCH] x86/mce: Handle varying MCA bank counts >

Re: [PATCH] x86/mce: Handle varying MCA bank counts

2018-07-27 Thread Luck, Tony
On Fri, Jul 27, 2018 at 04:40:09PM -0500, Yazen Ghannam wrote: > - /* Don't support asymmetric configurations today */ > - WARN_ON(mca_cfg.banks != 0 && b != mca_cfg.banks); > - mca_cfg.banks = b; > + mca_cfg.banks = max(mca_cfg.banks, b); Should we change mca_cfg.banks to be a

Re: [PATCH] x86/mce: Handle varying MCA bank counts

2018-07-27 Thread Luck, Tony
On Fri, Jul 27, 2018 at 04:40:09PM -0500, Yazen Ghannam wrote: > - /* Don't support asymmetric configurations today */ > - WARN_ON(mca_cfg.banks != 0 && b != mca_cfg.banks); > - mca_cfg.banks = b; > + mca_cfg.banks = max(mca_cfg.banks, b); Should we change mca_cfg.banks to be a

[PATCH] x86/mce: Handle varying MCA bank counts

2018-07-27 Thread Yazen Ghannam
From: Yazen Ghannam Linux reads MCG_CAP[Count] to find the number of MCA banks visible to a CPU. Currently, this is assumed to be the same for all CPUs and a warning is shown if there is a difference. The number of banks is overwritten with the MCG_CAP[Count] value of each following CPU that

[PATCH] x86/mce: Handle varying MCA bank counts

2018-07-27 Thread Yazen Ghannam
From: Yazen Ghannam Linux reads MCG_CAP[Count] to find the number of MCA banks visible to a CPU. Currently, this is assumed to be the same for all CPUs and a warning is shown if there is a difference. The number of banks is overwritten with the MCG_CAP[Count] value of each following CPU that