Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Baoquan He
On 05/02/17 at 09:24am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > On 05/01/17 at 03:37pm, Yinghai Lu wrote: > > > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > > > arch/x86/mm/init_64.c | 6 -- > > > > 1 file changed, 4 insertions(+), 2

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Baoquan He
On 05/02/17 at 09:24am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > On 05/01/17 at 03:37pm, Yinghai Lu wrote: > > > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > > > arch/x86/mm/init_64.c | 6 -- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > diff

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Ingo Molnar
* Baoquan He wrote: > On 05/01/17 at 03:37pm, Yinghai Lu wrote: > > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > > arch/x86/mm/init_64.c | 6 -- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/mm/init_64.c

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Ingo Molnar
* Baoquan He wrote: > On 05/01/17 at 03:37pm, Yinghai Lu wrote: > > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > > arch/x86/mm/init_64.c | 6 -- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > >

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Baoquan He
On 05/01/17 at 03:37pm, Yinghai Lu wrote: > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > arch/x86/mm/init_64.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index 15173d3..dbf4f00

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-02 Thread Baoquan He
On 05/01/17 at 03:37pm, Yinghai Lu wrote: > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > arch/x86/mm/init_64.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index 15173d3..dbf4f00 100644 > > ---

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Yinghai Lu
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' >

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Yinghai Lu
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' > won't. > > This is

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 7:52 AM, Baoquan He wrote: > On 05/01/17 at 07:40am, Dan Williams wrote: >> On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: >> > arch/x86/mm/init_64.c | 6 -- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> > diff --git

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 7:52 AM, Baoquan He wrote: > On 05/01/17 at 07:40am, Dan Williams wrote: >> On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: >> > arch/x86/mm/init_64.c | 6 -- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/x86/mm/init_64.c

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
On 05/01/17 at 08:24am, Dan Williams wrote: > On Mon, May 1, 2017 at 7:52 AM, Baoquan He wrote: > > On 05/01/17 at 07:40am, Dan Williams wrote: > >> On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > >> > arch/x86/mm/init_64.c | 6 -- > >> > 1 file

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
On 05/01/17 at 08:24am, Dan Williams wrote: > On Mon, May 1, 2017 at 7:52 AM, Baoquan He wrote: > > On 05/01/17 at 07:40am, Dan Williams wrote: > >> On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > >> > arch/x86/mm/init_64.c | 6 -- > >> > 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
On 05/01/17 at 07:40am, Dan Williams wrote: > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > arch/x86/mm/init_64.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index 15173d3..dbf4f00

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
On 05/01/17 at 07:40am, Dan Williams wrote: > On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > arch/x86/mm/init_64.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > index 15173d3..dbf4f00 100644 > > ---

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' >

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' > won't. > > This is

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Thomas Garnier
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' >

Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Thomas Garnier
On Mon, May 1, 2017 at 4:41 AM, Baoquan He wrote: > > Jeff Moyer reported that on his system with two memory regions 0~64G and > 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr > will make system hang intermittently during boot. While adding 'nokaslr' > won't. > > This is

[PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
Jeff Moyer reported that on his system with two memory regions 0~64G and 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr will make system hang intermittently during boot. While adding 'nokaslr' won't. This is because the for loop count calculation in sync_global_pgds is

[PATCH] x86/mm: Fix incorrect for loop count calculation in sync_global_pgds

2017-05-01 Thread Baoquan He
Jeff Moyer reported that on his system with two memory regions 0~64G and 1T~1T+192G, and kernel option "memmap=192G!1024G" added, enabling kaslr will make system hang intermittently during boot. While adding 'nokaslr' won't. This is because the for loop count calculation in sync_global_pgds is