Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-26 Thread Tejun Heo
Hello, Dave. On Mon, Jan 25, 2021 at 04:47:42PM -0800, Dave Hansen wrote: > The patch here does not actually separate out pre-boot from post-boot, > so it's pretty hard to tell if the splits came from something like > tracing which is totally unnecessary or they were the result of > something at

Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-26 Thread Tejun Heo
Hello, On Mon, Jan 25, 2021 at 05:04:00PM -0800, Dave Hansen wrote: > Which part? Large production environments don't trust data from > debugfs? Or don't trust it if it might have been reset? When the last reset was. Not saying it's impossible or anything but in general it's a lot better to

Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-26 Thread Dave Hansen
On 1/25/21 4:53 PM, Tejun Heo wrote: >> This would be a lot more useful if you could reset the counters. Then >> just reset them from userspace at boot. Adding read-write debugfs >> exports for these should be pretty trivial. > While this would work for hands-on cases, I'm a bit worried that

Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-26 Thread Dave Hansen
On 1/25/21 12:32 PM, Tejun Heo wrote: > On Mon, Jan 25, 2021 at 12:15:51PM -0800, Dave Hansen wrote: >>> DirectMap4k: 3505112 kB >>> DirectMap2M:19464192 kB >>> DirectMap1G:12582912 kB >>> DirectMap2MSplits: 1705 >>> DirectMap1GSplits:20 >> This seems much more like something we'd

Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-25 Thread Tejun Heo
Hello, On Mon, Jan 25, 2021 at 12:15:51PM -0800, Dave Hansen wrote: > > DirectMap4k: 3505112 kB > > DirectMap2M:19464192 kB > > DirectMap1G:12582912 kB > > DirectMap2MSplits: 1705 > > DirectMap1GSplits:20 > > This seems much more like something we'd want in /proc/vmstat or as a

Re: [PATCH] x86/mm: Tracking linear mapping split events since boot

2021-01-25 Thread Dave Hansen
On 1/25/21 12:11 PM, Saravanan D wrote: > Numerous hugepage splits in the linear mapping would give > admins the signal to narrow down the sluggishness caused by TLB > miss/reload. > > One of the many lasting (as we don't coalesce back) sources for huge page > splits is tracing as the granular