Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-04 Thread Dou Liyang
Hi Thomas, At 07/04/2017 03:19 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Dou Liyang wrote: At 07/03/2017 10:22 PM, Colin King wrote: -int normal_busy(struct bau_control *bcp) +static int normal_busy(struct bau_control *bcp) In my opinion, there is no need to mark *normal_busy* static,

Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-04 Thread Dou Liyang
Hi Thomas, At 07/04/2017 03:19 PM, Thomas Gleixner wrote: On Tue, 4 Jul 2017, Dou Liyang wrote: At 07/03/2017 10:22 PM, Colin King wrote: -int normal_busy(struct bau_control *bcp) +static int normal_busy(struct bau_control *bcp) In my opinion, there is no need to mark *normal_busy* static,

Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-04 Thread Thomas Gleixner
On Tue, 4 Jul 2017, Dou Liyang wrote: > At 07/03/2017 10:22 PM, Colin King wrote: > > -int normal_busy(struct bau_control *bcp) > > +static int normal_busy(struct bau_control *bcp) > > In my opinion, there is no need to mark *normal_busy* static, remove it > directly. > > the commit

Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-04 Thread Thomas Gleixner
On Tue, 4 Jul 2017, Dou Liyang wrote: > At 07/03/2017 10:22 PM, Colin King wrote: > > -int normal_busy(struct bau_control *bcp) > > +static int normal_busy(struct bau_control *bcp) > > In my opinion, there is no need to mark *normal_busy* static, remove it > directly. > > the commit

Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-03 Thread Dou Liyang
Hi Colin, At 07/03/2017 10:22 PM, Colin King wrote: From: Colin Ian King Functions normal_busy, handle_uv2_busy, uv_flush_send_and_wait and find_another_by_swack are local to the source, so make them static Fixes various smatch warnings, such as: "symbol

Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-03 Thread Dou Liyang
Hi Colin, At 07/03/2017 10:22 PM, Colin King wrote: From: Colin Ian King Functions normal_busy, handle_uv2_busy, uv_flush_send_and_wait and find_another_by_swack are local to the source, so make them static Fixes various smatch warnings, such as: "symbol 'find_another_by_swack' was not

[PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-03 Thread Colin King
From: Colin Ian King Functions normal_busy, handle_uv2_busy, uv_flush_send_and_wait and find_another_by_swack are local to the source, so make them static Fixes various smatch warnings, such as: "symbol 'find_another_by_swack' was not declared. Should it be static?"

[PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static

2017-07-03 Thread Colin King
From: Colin Ian King Functions normal_busy, handle_uv2_busy, uv_flush_send_and_wait and find_another_by_swack are local to the source, so make them static Fixes various smatch warnings, such as: "symbol 'find_another_by_swack' was not declared. Should it be static?" "symbol 'handle_uv2_busy'