Re: [PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread Matthew Rickard
On 17/08/2018 5:41 AM, Andy Lutomirski wrote: Currently, if the vDSO ends up containing an indirect branch or call, GCC will emit the "external thunk" style of retpoline, and it will fail to link. Fix it by building the vDSO with inline retpoline thunks. I haven't seen any reports of this

Re: [PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread Matthew Rickard
On 17/08/2018 5:41 AM, Andy Lutomirski wrote: Currently, if the vDSO ends up containing an indirect branch or call, GCC will emit the "external thunk" style of retpoline, and it will fail to link. Fix it by building the vDSO with inline retpoline thunks. I haven't seen any reports of this

Re: [PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread David Woodhouse
On Thu, 2018-08-16 at 12:41 -0700, Andy Lutomirski wrote: > Currently, if the vDSO ends up containing an indirect branch or > call, GCC will emit the "external thunk" style of retpoline, and it > will fail to link. > > Fix it by building the vDSO with inline retpoline thunks. > > I haven't

Re: [PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread David Woodhouse
On Thu, 2018-08-16 at 12:41 -0700, Andy Lutomirski wrote: > Currently, if the vDSO ends up containing an indirect branch or > call, GCC will emit the "external thunk" style of retpoline, and it > will fail to link. > > Fix it by building the vDSO with inline retpoline thunks. > > I haven't

[PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread Andy Lutomirski
Currently, if the vDSO ends up containing an indirect branch or call, GCC will emit the "external thunk" style of retpoline, and it will fail to link. Fix it by building the vDSO with inline retpoline thunks. I haven't seen any reports of this triggering on an unpatched kernel. Cc: Matt Rickard

[PATCH] x86/vdso: Fix vDSO build if a retpoline is emitted

2018-08-16 Thread Andy Lutomirski
Currently, if the vDSO ends up containing an indirect branch or call, GCC will emit the "external thunk" style of retpoline, and it will fail to link. Fix it by building the vDSO with inline retpoline thunks. I haven't seen any reports of this triggering on an unpatched kernel. Cc: Matt Rickard