Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-06 Thread Randy Dunlap
Ian Campbell wrote: On Tue, 2008-02-05 at 17:09 -0800, Randy Dunlap wrote: On Fri, 01 Feb 2008 09:02:48 + Ian Campbell wrote: + THE IMAGE CHECKSUM + +The CRC-32 is calculated over the entire file using an initial +remainder of 0x. The checksum is appended to the file Run-on

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-06 Thread Ian Campbell
On Tue, 2008-02-05 at 17:09 -0800, Randy Dunlap wrote: > On Fri, 01 Feb 2008 09:02:48 + Ian Campbell wrote: > > > > + THE IMAGE CHECKSUM > > + > > +The CRC-32 is calculated over the entire file using an initial > > +remainder of 0x. The checksum is appended to the file > >

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-06 Thread Randy Dunlap
Ian Campbell wrote: On Tue, 2008-02-05 at 17:09 -0800, Randy Dunlap wrote: On Fri, 01 Feb 2008 09:02:48 + Ian Campbell wrote: + THE IMAGE CHECKSUM + +The CRC-32 is calculated over the entire file using an initial +remainder of 0x. The checksum is appended to the file Run-on

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-05 Thread Randy Dunlap
On Fri, 01 Feb 2008 09:02:48 + Ian Campbell wrote: > --- > >From 1c614383dc9cb0c7791ebab386dc012db336b28c Mon Sep 17 00:00:00 2001 > From: Ian Campbell <[EMAIL PROTECTED]> > Date: Fri, 1 Feb 2008 09:01:22 +0000 > Subject: [PATCH] x86: add a crc32 checksum to the kerne

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-05 Thread Randy Dunlap
On Fri, 01 Feb 2008 09:02:48 + Ian Campbell wrote: --- From 1c614383dc9cb0c7791ebab386dc012db336b28c Mon Sep 17 00:00:00 2001 From: Ian Campbell [EMAIL PROTECTED] Date: Fri, 1 Feb 2008 09:01:22 + Subject: [PATCH] x86: add a crc32 checksum to the kernel image. Signed-off-by: Ian

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ingo Molnar
* Ian Campbell <[EMAIL PROTECTED]> wrote: > > * Please don't use "unsigned long" to represent a 32-bit number. > > Fixed. thanks, applied. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ian Campbell
On Thu, 2008-01-31 at 17:16 -0800, H. Peter Anvin wrote: > David Newall wrote: > > Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is > > surely enough. > > As long as it can be included in user-space code we should use that one. I don't think it can. There is a main

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ian Campbell
gt; * Please don't use "unsigned long" to represent a 32-bit number. Fixed. --- >From 1c614383dc9cb0c7791ebab386dc012db336b28c Mon Sep 17 00:00:00 2001 From: Ian Campbell <[EMAIL PROTECTED]> Date: Fri, 1 Feb 2008 09:01:22 + Subject: [PATCH] x86: add a crc32 checksum to

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ian Campbell
. Fixed. --- From 1c614383dc9cb0c7791ebab386dc012db336b28c Mon Sep 17 00:00:00 2001 From: Ian Campbell [EMAIL PROTECTED] Date: Fri, 1 Feb 2008 09:01:22 + Subject: [PATCH] x86: add a crc32 checksum to the kernel image. Signed-off-by: Ian Campbell [EMAIL PROTECTED] Cc: Thomas Gleixner [EMAIL

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ian Campbell
On Thu, 2008-01-31 at 17:16 -0800, H. Peter Anvin wrote: David Newall wrote: Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is surely enough. As long as it can be included in user-space code we should use that one. I don't think it can. There is a main function

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-02-01 Thread Ingo Molnar
* Ian Campbell [EMAIL PROTECTED] wrote: * Please don't use unsigned long to represent a 32-bit number. Fixed. thanks, applied. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread David Newall
H. Peter Anvin wrote: > David Newall wrote: >> Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is >> surely enough. > > As long as it can be included in user-space code we should use that one. You're right. I misread the patch. I thought the calculation was being added to

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread H. Peter Anvin
David Newall wrote: Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is surely enough. As long as it can be included in user-space code we should use that one. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread David Newall
Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is surely enough. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread H. Peter Anvin
H. Peter Anvin wrote: Hm. I have some minor concerns about this: * The classical length field is only available in multiples of 16 (I realize your patches change that to some degree, but I'd hate to make the guarantee that the image payload is the last thing in the image -- it loses

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread H. Peter Anvin
Ian Campbell wrote: Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> Cc: Thomas Gleixner <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTECTED]> Cc: H. Peter Anvin <[EMAIL PROTECTED]> --- Documentation/i386/boot.txt |5 +++ arch/x86/boot/tools/build.c | 78

[PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread Ian Campbell
Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> Cc: Thomas Gleixner <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTECTED]> Cc: H. Peter Anvin <[EMAIL PROTECTED]> --- Documentation/i386/boot.txt |5 +++ arch/x86/boot/tools/build.c | 78 +++ 2 files

[PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread Ian Campbell
Signed-off-by: Ian Campbell [EMAIL PROTECTED] Cc: Thomas Gleixner [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- Documentation/i386/boot.txt |5 +++ arch/x86/boot/tools/build.c | 78 +++ 2 files changed,

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread H. Peter Anvin
Ian Campbell wrote: Signed-off-by: Ian Campbell [EMAIL PROTECTED] Cc: Thomas Gleixner [EMAIL PROTECTED] Cc: Ingo Molnar [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- Documentation/i386/boot.txt |5 +++ arch/x86/boot/tools/build.c | 78

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread H. Peter Anvin
H. Peter Anvin wrote: Hm. I have some minor concerns about this: * The classical length field is only available in multiples of 16 (I realize your patches change that to some degree, but I'd hate to make the guarantee that the image payload is the last thing in the image -- it loses

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread David Newall
Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is surely enough. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] x86: add a crc32 checksum to the kernel image.

2008-01-31 Thread David Newall
H. Peter Anvin wrote: David Newall wrote: Isn't a crc32 calculation already defined? Yes; in lib/crc32.c. One is surely enough. As long as it can be included in user-space code we should use that one. You're right. I misread the patch. I thought the calculation was being added to kernel