Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread H. Peter Anvin
Kyle McMartin wrote: On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote: +#ifdef CONFIG_X86_F00F_BUG +void do_invalid_op(struct pt_regs *, unsigned long); +#endif + +static int is_f00f_bug(struct pt_regs *regs, unsigned long address) +{ +#ifdef CONFIG_X86_F00F_BUG + unsigned

Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread Kyle McMartin
On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote: > +#ifdef CONFIG_X86_F00F_BUG > +void do_invalid_op(struct pt_regs *, unsigned long); > +#endif > + > +static int is_f00f_bug(struct pt_regs *regs, unsigned long address) > +{ > +#ifdef CONFIG_X86_F00F_BUG > + unsigned long nr;

[PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread Harvey Harrison
Further towards unifying these files, add another helper in same spirit as is_errata93. Add an #ifdef around the forward declaration of do_invalid_op to make it clear it is only needed in the one place. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/mm/fault_32.c | 41

[PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread Harvey Harrison
Further towards unifying these files, add another helper in same spirit as is_errata93. Add an #ifdef around the forward declaration of do_invalid_op to make it clear it is only needed in the one place. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/mm/fault_32.c | 41

Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread Kyle McMartin
On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote: +#ifdef CONFIG_X86_F00F_BUG +void do_invalid_op(struct pt_regs *, unsigned long); +#endif + +static int is_f00f_bug(struct pt_regs *regs, unsigned long address) +{ +#ifdef CONFIG_X86_F00F_BUG + unsigned long nr; You can

Re: [PATCH] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-15 Thread H. Peter Anvin
Kyle McMartin wrote: On Tue, Jan 15, 2008 at 06:48:35PM -0800, Harvey Harrison wrote: +#ifdef CONFIG_X86_F00F_BUG +void do_invalid_op(struct pt_regs *, unsigned long); +#endif + +static int is_f00f_bug(struct pt_regs *regs, unsigned long address) +{ +#ifdef CONFIG_X86_F00F_BUG + unsigned