Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-18 Thread Matt Fleming
On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > > x86_init.oem.arch_setup(); > > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > > > parse_early_param(); > > > > > > + if (efi_enabled(EFI_BOOT)) > > > +

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-18 Thread Matt Fleming
On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > > x86_init.oem.arch_setup(); > > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > > > parse_early_param(); > > > > > > + if (efi_enabled(EFI_BOOT)) > > > +

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-16 Thread Ingo Molnar
* Matt Fleming wrote: > > x86_init.oem.arch_setup(); > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > parse_early_param(); > > > > + if (efi_enabled(EFI_BOOT)) > > + efi_memblock_x86_reserve_range(); > > #ifdef

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-16 Thread Ingo Molnar
* Matt Fleming wrote: > > x86_init.oem.arch_setup(); > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > parse_early_param(); > > > > + if (efi_enabled(EFI_BOOT)) > > + efi_memblock_x86_reserve_range(); > > #ifdef CONFIG_MEMORY_HOTPLUG > > /* >

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-16 Thread Ingo Molnar
* Dave Young wrote: > Another way is move "efi_memblock_x86_reserve_range" to later code > Maybe below is better? Yeah, that's much lower risk, if the affected EFI code does not mind being called later. We had trouble from trying to move early param parsing wholesale.

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-16 Thread Ingo Molnar
* Dave Young wrote: > Another way is move "efi_memblock_x86_reserve_range" to later code > Maybe below is better? Yeah, that's much lower risk, if the affected EFI code does not mind being called later. We had trouble from trying to move early param parsing wholesale. I've applied your v2

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-15 Thread Matt Fleming
On Thu, 14 Dec, at 06:41:19PM, Dave Young wrote: > On 11/30/17 at 01:23pm, Dave Young wrote: > > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > > chance to run because the code path is before parse_early_param(). > > I believe it worked when the param was introduced but

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-15 Thread Matt Fleming
On Thu, 14 Dec, at 06:41:19PM, Dave Young wrote: > On 11/30/17 at 01:23pm, Dave Young wrote: > > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > > chance to run because the code path is before parse_early_param(). > > I believe it worked when the param was introduced but

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-14 Thread Dave Young
On 11/30/17 at 01:23pm, Dave Young wrote: > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > chance to run because the code path is before parse_early_param(). > I believe it worked when the param was introduced but probably later > some other changes caused the wrong order and

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-14 Thread Dave Young
On 11/30/17 at 01:23pm, Dave Young wrote: > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > chance to run because the code path is before parse_early_param(). > I believe it worked when the param was introduced but probably later > some other changes caused the wrong order and

[PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-11-29 Thread Dave Young
'add_efi_memmap' is an early param, but do_add_efi_memmap() has no chance to run because the code path is before parse_early_param(). I believe it worked when the param was introduced but probably later some other changes caused the wrong order and nobody noticed it. Move parse_early_param before

[PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-11-29 Thread Dave Young
'add_efi_memmap' is an early param, but do_add_efi_memmap() has no chance to run because the code path is before parse_early_param(). I believe it worked when the param was introduced but probably later some other changes caused the wrong order and nobody noticed it. Move parse_early_param before