Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-22 Thread Karel Zak
On Fri, Sep 19, 2014 at 11:15:05AM -0700, Dave Hansen wrote: > On 09/19/2014 04:45 AM, Karel Zak wrote: > > hmm... it would be also nice to test it with lscpu(1) from > > util-linux (but it uses maps rather than lists from cpu*/topology/). > > Here's the output with and with out Cluster-on-Die

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-22 Thread Karel Zak
On Fri, Sep 19, 2014 at 11:15:05AM -0700, Dave Hansen wrote: On 09/19/2014 04:45 AM, Karel Zak wrote: hmm... it would be also nice to test it with lscpu(1) from util-linux (but it uses maps rather than lists from cpu*/topology/). Here's the output with and with out Cluster-on-Die

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-21 Thread Brice Goglin
Le 18/09/2014 21:33, Dave Hansen a écrit : > After this set, there are only 2 sets of core siblings, which > is what we expect for a 2-socket system. > > # cat cpu*/topology/physical_package_id | sort | uniq -c > 18 0 > 18 1 > # cat cpu*/topology/core_siblings_list | sort | uniq -c >

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-21 Thread Brice Goglin
Le 18/09/2014 21:33, Dave Hansen a écrit : After this set, there are only 2 sets of core siblings, which is what we expect for a 2-socket system. # cat cpu*/topology/physical_package_id | sort | uniq -c 18 0 18 1 # cat cpu*/topology/core_siblings_list | sort | uniq -c 18

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Dave Hansen
On 09/19/2014 04:45 AM, Karel Zak wrote: > hmm... it would be also nice to test it with lscpu(1) from > util-linux (but it uses maps rather than lists from cpu*/topology/). Here's the output with and with out Cluster-on-Die enabled. Everything looks OK to me. The cache size changes are what

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Peter Zijlstra
On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote: > > > This is my third attempt to fix this. It's definitely simpler > than the previous set. This takes Peter Z's suggestion to just > create and use a different topology when we see these > "Cluster-on-Die" systems. > +static

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Karel Zak
On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote: > The sysfs effects here cause an issue with the hwloc tool where > it gets confused and thinks there are more sockets than are > physically present. > > Before this patch, there are two packages: > > # cd /sys/devices/system/cpu/ > #

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Karel Zak
On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote: The sysfs effects here cause an issue with the hwloc tool where it gets confused and thinks there are more sockets than are physically present. Before this patch, there are two packages: # cd /sys/devices/system/cpu/ # cat

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Peter Zijlstra
On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote: This is my third attempt to fix this. It's definitely simpler than the previous set. This takes Peter Z's suggestion to just create and use a different topology when we see these Cluster-on-Die systems. +static struct

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-19 Thread Dave Hansen
On 09/19/2014 04:45 AM, Karel Zak wrote: hmm... it would be also nice to test it with lscpu(1) from util-linux (but it uses maps rather than lists from cpu*/topology/). Here's the output with and with out Cluster-on-Die enabled. Everything looks OK to me. The cache size changes are what

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-18 Thread Dave Hansen
On 09/18/2014 12:33 PM, Dave Hansen wrote: > @@ -410,6 +442,8 @@ void set_cpu_sibling_map(int cpu) > } else if (i != cpu && !c->booted_cores) > c->booted_cores = cpu_data(i).booted_cores; > } > + if (match_mc(c, o) ==

[PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-18 Thread Dave Hansen
This is my third attempt to fix this. It's definitely simpler than the previous set. This takes Peter Z's suggestion to just create and use a different topology when we see these "Cluster-on-Die" systems. -- From: Dave Hansen I'm getting the spew below when booting with Haswell (Xeon

Re: [PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-18 Thread Dave Hansen
On 09/18/2014 12:33 PM, Dave Hansen wrote: @@ -410,6 +442,8 @@ void set_cpu_sibling_map(int cpu) } else if (i != cpu !c-booted_cores) c-booted_cores = cpu_data(i).booted_cores; } + if (match_mc(c, o) ==

[PATCH] x86: new topology for multi-NUMA-node CPUs

2014-09-18 Thread Dave Hansen
This is my third attempt to fix this. It's definitely simpler than the previous set. This takes Peter Z's suggestion to just create and use a different topology when we see these Cluster-on-Die systems. -- From: Dave Hansen dave.han...@linux.intel.com I'm getting the spew below when booting