Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread H. Peter Anvin
Glauber de Oliveira Costa wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann3 escreveu: On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: So it could even work, but as accident. Unle

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann3 escreveu: > On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: >> On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: >>> So it could even work, but as accident. Unless I'm wrong about it, I'd >>

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann3
On Thu, Nov 01, 2007 at 06:35:43PM +0100, Andreas Herrmann3 wrote: > On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: > > So it could even work, but as accident. Unless I'm wrong about it, I'd > > prefer to see an explicit attribution of cpu_index = 0 somewhere for the > >

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann3
On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: > did you test it in a kernel without SMP compiled in ? > > I'm a little afraid about what can happen here: No I didn't, but should have done so - cpu_index exists only in the SMP case ... I'll come up with a corrected fi

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann escreveu: > This patch applies on current Linus' git with Glauber's recent cpuinfo fix > (http://marc.info/?l=linux-kernel&m=119392088227245) applied. > > > Regards, > > Andreas > Andreas, did you test it in a kernel without SMP

[PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann
This patch applies on current Linus' git with Glauber's recent cpuinfo fix (http://marc.info/?l=linux-kernel&m=119392088227245) applied. Regards, Andreas -- [PATCH] x86: show cpuinfo only for online CPUs Fix regressions introduced with 92cb7612aee39642d109b8d935ad265e602c0563.