OK, I assume Rusty will pick this up in his tree before pushing it to Linus.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
It works
Tested-by: Andy Shevchenko
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan wrote:
> On 24/04/13 02:00, H. Peter Anvin wrote:
>> On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
>>> On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b "module: fix symbol versioning with symbol
James Hogan wrote:
> How does the patch below look? I presume this is preferred over
> making VMLINUX_SYMBOL_STR non-argument-expanding?
>
> Thanks
> James
>
> Subject: [PATCH 1/1] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion
>
> Commit a4b6a77b77ba4f526392612c2365797fab956014 ("module:
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan wrote:
> On 24/04/13 02:00, H. Peter Anvin wrote:
>> On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
>> Either way -- James, Rusty, this is in your court.
>
> How does the patch below look? I presume this is preferred over
> making VMLINUX_SYMBOL_STR
On 24/04/13 02:00, H. Peter Anvin wrote:
> On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
>> On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
>>> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
>>> loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
>>
>>
On 24/04/13 02:00, H. Peter Anvin wrote:
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
This really does
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan james.ho...@imgtec.com wrote:
On 24/04/13 02:00, H. Peter Anvin wrote:
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
Either way -- James, Rusty, this is in your court.
How does the patch below look? I presume this is preferred over
making
James Hogan wrote:
How does the patch below look? I presume this is preferred over
making VMLINUX_SYMBOL_STR non-argument-expanding?
Thanks
James
Subject: [PATCH 1/1] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion
Commit a4b6a77b77ba4f526392612c2365797fab956014 (module: fix symbol
It works
Tested-by: Andy Shevchenko andriy.shevche...@linux.intel.com
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan james.ho...@imgtec.com wrote:
On 24/04/13 02:00, H. Peter Anvin wrote:
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b
OK, I assume Rusty will pick this up in his tree before pushing it to Linus.
-hpa
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
> On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
>> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
>> loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
>
> This really does seem to be the offending
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
> loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
This really does seem to be the offending commit, although I'm still
confused how the heck that is
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
> loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
>
> # modprobe ipv6
> FATAL: Error inserting ipv6
>
On 04/23/2013 08:41 AM, Andy Shevchenko wrote:
> On Tue, Apr 23, 2013 at 6:17 PM, H. Peter Anvin wrote:
>> On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
>>>
>>> -#define memcmp __builtin_memcmp
>>> +int memcmp(const void *cs, const void *ct, size_t count);
>>>
>>
>> Yuck. I really don't like this
On Tue, Apr 23, 2013 at 6:17 PM, H. Peter Anvin wrote:
> On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
>>
>> -#define memcmp __builtin_memcmp
>> +int memcmp(const void *cs, const void *ct, size_t count);
>>
>
> Yuck. I really don't like this option unless it truly can't be
> avoided... it might be
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
>
> -#define memcmp __builtin_memcmp
> +int memcmp(const void *cs, const void *ct, size_t count);
>
Yuck. I really don't like this option unless it truly can't be
avoided... it might be a fix for 3.9/stable but a better way to do this
would be much
On Tue, Apr 23, 2013 at 3:40 PM, Tetsuo Handa
wrote:
> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
> loading of net/ipv6/ipv6.ko
I would rephrase this to "any module uses memcmp, e.g. ipv6"
Otherwise: Reviewed-by: Andy Shevchenko
...and
Tested-by: Andy Shevchenko
Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
# modprobe ipv6
FATAL: Error inserting ipv6
(/lib/modules/3.9.0-rc8-next-20130422/kernel/net/ipv6/ipv6.ko): Invalid argument
# dmesg
ipv6: no
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
# modprobe ipv6
FATAL: Error inserting ipv6
(/lib/modules/3.9.0-rc8-next-20130422/kernel/net/ipv6/ipv6.ko): Invalid argument
# dmesg
ipv6: no
On Tue, Apr 23, 2013 at 3:40 PM, Tetsuo Handa
penguin-ker...@i-love.sakura.ne.jp wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko
I would rephrase this to any module uses memcmp, e.g. ipv6
Otherwise: Reviewed-by: Andy Shevchenko
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
-#define memcmp __builtin_memcmp
+int memcmp(const void *cs, const void *ct, size_t count);
Yuck. I really don't like this option unless it truly can't be
avoided... it might be a fix for 3.9/stable but a better way to do this
would be much
On Tue, Apr 23, 2013 at 6:17 PM, H. Peter Anvin h...@zytor.com wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
-#define memcmp __builtin_memcmp
+int memcmp(const void *cs, const void *ct, size_t count);
Yuck. I really don't like this option unless it truly can't be
avoided... it might
On 04/23/2013 08:41 AM, Andy Shevchenko wrote:
On Tue, Apr 23, 2013 at 6:17 PM, H. Peter Anvin h...@zytor.com wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
-#define memcmp __builtin_memcmp
+int memcmp(const void *cs, const void *ct, size_t count);
Yuck. I really don't like this
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
# modprobe ipv6
FATAL: Error inserting ipv6
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
This really does seem to be the offending commit, although I'm still
confused how the heck that is
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32.
This really does seem to be the offending commit,
26 matches
Mail list logo
