Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Matt Fleming
On Wed, 15 Apr, at 11:56:05AM, Roy Franz wrote: > Yeah, I guess it shouldn't surprise me that there is support for 64 > bit addresses there :) > > I'l spin another patch that sets boot_params->ext_cmd_line_ptr with > the upper 32 bits of the address. > Should I conditionalize this with #ifdef

Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Roy Franz
On Wed, Apr 15, 2015 at 6:18 AM, Matt Fleming wrote: > On Tue, 14 Apr, at 05:45:52PM, Roy Franz wrote: >> The boot_params structure has a 32 bit field for storing the address of >> the kernel command line. When the EFI stub allocates memory for the command >> line, it allocates at as low and

Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Matt Fleming
On Tue, 14 Apr, at 05:45:52PM, Roy Franz wrote: > The boot_params structure has a 32 bit field for storing the address of > the kernel command line. When the EFI stub allocates memory for the command > line, it allocates at as low and address as possible, but does not ensure > that the address of

Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Matt Fleming
On Tue, 14 Apr, at 05:45:52PM, Roy Franz wrote: The boot_params structure has a 32 bit field for storing the address of the kernel command line. When the EFI stub allocates memory for the command line, it allocates at as low and address as possible, but does not ensure that the address of

Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Matt Fleming
On Wed, 15 Apr, at 11:56:05AM, Roy Franz wrote: Yeah, I guess it shouldn't surprise me that there is support for 64 bit addresses there :) I'l spin another patch that sets boot_params-ext_cmd_line_ptr with the upper 32 bits of the address. Should I conditionalize this with #ifdef

Re: [PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-15 Thread Roy Franz
On Wed, Apr 15, 2015 at 6:18 AM, Matt Fleming m...@codeblueprint.co.uk wrote: On Tue, 14 Apr, at 05:45:52PM, Roy Franz wrote: The boot_params structure has a 32 bit field for storing the address of the kernel command line. When the EFI stub allocates memory for the command line, it allocates

[PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-14 Thread Roy Franz
The boot_params structure has a 32 bit field for storing the address of the kernel command line. When the EFI stub allocates memory for the command line, it allocates at as low and address as possible, but does not ensure that the address of memory allocated is below 4G. This patch enforces this

[PATCH] x86_64/efi: enforce 32 bit address for command line buffer

2015-04-14 Thread Roy Franz
The boot_params structure has a 32 bit field for storing the address of the kernel command line. When the EFI stub allocates memory for the command line, it allocates at as low and address as possible, but does not ensure that the address of memory allocated is below 4G. This patch enforces this