Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-11 Thread Andreas Herrmann
On Tue, Apr 10, 2007 at 08:11:18PM +0200, Andi Kleen wrote: > On Tuesday 10 April 2007 19:24:25 Andreas Herrmann wrote: > > This fix is needed for AMD family 10h CPUs. > > > > It prevents auto select of mwait_idle for AMD CPUs. > > MWAIT does not enter C-states on family 10h and more > > power

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-11 Thread Andreas Herrmann
On Tue, Apr 10, 2007 at 08:11:18PM +0200, Andi Kleen wrote: On Tuesday 10 April 2007 19:24:25 Andreas Herrmann wrote: This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andi Kleen
On Tuesday 10 April 2007 19:24:25 Andreas Herrmann wrote: > This fix is needed for AMD family 10h CPUs. > > It prevents auto select of mwait_idle for AMD CPUs. > MWAIT does not enter C-states on family 10h and more > power saving is reached by entering C1 with > default_idle. > > The patch also

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
Actually I have also written patches to clear the MWAIT flag for AMD CPUs. But after re-reading of specs (also Intel's specs) I preferred to keep the MWAIT flag but to introduce a MWAIT_NO_CSTATE flag. I think this is the cleaner solution. Regards, Andreas - To unsubscribe from this list:

[PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is reached by entering C1 with default_idle. The patch also adds an idle=mwait command line option to select mwait_idle for

[PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is reached by entering C1 with default_idle. The patch also adds an idle=mwait command line option to select mwait_idle for

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
Actually I have also written patches to clear the MWAIT flag for AMD CPUs. But after re-reading of specs (also Intel's specs) I preferred to keep the MWAIT flag but to introduce a MWAIT_NO_CSTATE flag. I think this is the cleaner solution. Regards, Andreas - To unsubscribe from this list:

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andi Kleen
On Tuesday 10 April 2007 19:24:25 Andreas Herrmann wrote: This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is reached by entering C1 with default_idle. The patch also adds an