Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-07 Thread Konrad Rzeszutek Wilk
On Thu, Dec 06, 2012 at 05:02:50PM +, Jan Beulich wrote: > >>> On 06.12.12 at 17:23, Olaf Hering wrote: > > On Wed, Dec 05, Jan Beulich wrote: > > > >> >>> On 05.12.12 at 11:01, Olaf Hering wrote: > >> > backend_changed might be called multiple times, which will leak > >> > be->mode. free

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-07 Thread Konrad Rzeszutek Wilk
On Thu, Dec 06, 2012 at 05:02:50PM +, Jan Beulich wrote: On 06.12.12 at 17:23, Olaf Hering o...@aepfle.de wrote: On Wed, Dec 05, Jan Beulich wrote: On 05.12.12 at 11:01, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode.

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Thu, Dec 06, Jan Beulich wrote: > >>> On 06.12.12 at 17:23, Olaf Hering wrote: > > On Wed, Dec 05, Jan Beulich wrote: > > > >> >>> On 05.12.12 at 11:01, Olaf Hering wrote: > >> > backend_changed might be called multiple times, which will leak > >> > be->mode. free the previous value before

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Jan Beulich
>>> On 06.12.12 at 17:23, Olaf Hering wrote: > On Wed, Dec 05, Jan Beulich wrote: > >> >>> On 05.12.12 at 11:01, Olaf Hering wrote: >> > backend_changed might be called multiple times, which will leak >> > be->mode. free the previous value before storing the current mode value. >> >> As said

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Wed, Dec 05, Jan Beulich wrote: > >>> On 05.12.12 at 11:01, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. free the previous value before storing the current mode value. > > As said before - this is one possible route to take. But did you

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Wed, Dec 05, Jan Beulich wrote: On 05.12.12 at 11:01, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. free the previous value before storing the current mode value. As said before - this is one possible route to take. But did

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Jan Beulich
On 06.12.12 at 17:23, Olaf Hering o...@aepfle.de wrote: On Wed, Dec 05, Jan Beulich wrote: On 05.12.12 at 11:01, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. free the previous value before storing the current mode value. As

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-06 Thread Olaf Hering
On Thu, Dec 06, Jan Beulich wrote: On 06.12.12 at 17:23, Olaf Hering o...@aepfle.de wrote: On Wed, Dec 05, Jan Beulich wrote: On 05.12.12 at 11:01, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. free the previous value

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Jan Beulich
>>> On 05.12.12 at 11:01, Olaf Hering wrote: > backend_changed might be called multiple times, which will leak > be->mode. free the previous value before storing the current mode value. As said before - this is one possible route to take. But did you consider at all the alternative of preventing

[PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be->mode. free the previous value before storing the current mode value. Signed-off-by: Olaf Hering --- !! Not compile tested !! drivers/block/xen-blkback/xenbus.c | 12 +++- 1 file changed, 7 insertions(+), 5

[PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be-mode. free the previous value before storing the current mode value. Signed-off-by: Olaf Hering o...@aepfle.de --- !! Not compile tested !! drivers/block/xen-blkback/xenbus.c | 12 +++- 1 file changed, 7 insertions(+),

Re: [PATCH] xen/blkback: prevent leak of mode during multiple backend_changed calls

2012-12-05 Thread Jan Beulich
On 05.12.12 at 11:01, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. free the previous value before storing the current mode value. As said before - this is one possible route to take. But did you consider at all the alternative of