Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-19 Thread Konrad Rzeszutek Wilk
On Thu, Dec 13, 2012 at 03:02:11PM +, Jan Beulich wrote: > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. Make sure it will be called only once. Remove some unneeded > > checks. Also the be->mode string was

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-19 Thread Konrad Rzeszutek Wilk
On Thu, Dec 13, 2012 at 03:02:11PM +, Jan Beulich wrote: On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-13 Thread Jan Beulich
>>> On 11.12.12 at 21:50, Olaf Hering wrote: > backend_changed might be called multiple times, which will leak > be->mode. Make sure it will be called only once. Remove some unneeded > checks. Also the be->mode string was leaked, release the memory on > device shutdown. So I decided to make an

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-13 Thread Jan Beulich
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was leaked, release the memory on device shutdown. So I decided to make

Re: [Xen-devel] [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Ian Campbell wrote: > On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote: > > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > > backend_changed might be called multiple times, which will leak > > > be->mode. Make sure it will be called only once. Remove some unneeded > > >

Re: [Xen-devel] [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Ian Campbell
On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote: > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. Make sure it will be called only once. Remove some unneeded > > checks. Also the be->mode string was leaked,

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Jan Beulich
>>> On 12.12.12 at 10:47, Olaf Hering wrote: > On Wed, Dec 12, Jan Beulich wrote: > >> >>> On 11.12.12 at 21:50, Olaf Hering wrote: >> > backend_changed might be called multiple times, which will leak >> > be->mode. Make sure it will be called only once. Remove some unneeded >> > checks. Also

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Jan Beulich wrote: > >>> On 11.12.12 at 21:50, Olaf Hering wrote: > > backend_changed might be called multiple times, which will leak > > be->mode. Make sure it will be called only once. Remove some unneeded > > checks. Also the be->mode string was leaked, release the memory on >

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Jan Beulich
>>> On 11.12.12 at 21:50, Olaf Hering wrote: > backend_changed might be called multiple times, which will leak > be->mode. Make sure it will be called only once. Remove some unneeded > checks. Also the be->mode string was leaked, release the memory on > device shutdown. So did I miss some

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Jan Beulich
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was leaked, release the memory on device shutdown. So did I miss some

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Jan Beulich wrote: On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was leaked, release the memory on

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Jan Beulich
On 12.12.12 at 10:47, Olaf Hering o...@aepfle.de wrote: On Wed, Dec 12, Jan Beulich wrote: On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded

Re: [Xen-devel] [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Ian Campbell
On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote: On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was leaked,

Re: [Xen-devel] [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-12 Thread Olaf Hering
On Wed, Dec 12, Ian Campbell wrote: On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote: On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote: backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded

[PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-11 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be->mode. Make sure it will be called only once. Remove some unneeded checks. Also the be->mode string was leaked, release the memory on device shutdown. Signed-off-by: Olaf Hering --- incorporate all comments from Jan. fold the

[PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-11 Thread Olaf Hering
backend_changed might be called multiple times, which will leak be-mode. Make sure it will be called only once. Remove some unneeded checks. Also the be-mode string was leaked, release the memory on device shutdown. Signed-off-by: Olaf Hering o...@aepfle.de --- incorporate all comments from Jan.