On Thu, Dec 13, 2012 at 03:02:11PM +, Jan Beulich wrote:
> >>> On 11.12.12 at 21:50, Olaf Hering wrote:
> > backend_changed might be called multiple times, which will leak
> > be->mode. Make sure it will be called only once. Remove some unneeded
> > checks. Also the be->mode string was
On Thu, Dec 13, 2012 at 03:02:11PM +, Jan Beulich wrote:
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was
>>> On 11.12.12 at 21:50, Olaf Hering wrote:
> backend_changed might be called multiple times, which will leak
> be->mode. Make sure it will be called only once. Remove some unneeded
> checks. Also the be->mode string was leaked, release the memory on
> device shutdown.
So I decided to make an
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was leaked, release the memory on
device shutdown.
So I decided to make
On Wed, Dec 12, Ian Campbell wrote:
> On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote:
> > >>> On 11.12.12 at 21:50, Olaf Hering wrote:
> > > backend_changed might be called multiple times, which will leak
> > > be->mode. Make sure it will be called only once. Remove some unneeded
> > >
On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote:
> >>> On 11.12.12 at 21:50, Olaf Hering wrote:
> > backend_changed might be called multiple times, which will leak
> > be->mode. Make sure it will be called only once. Remove some unneeded
> > checks. Also the be->mode string was leaked,
>>> On 12.12.12 at 10:47, Olaf Hering wrote:
> On Wed, Dec 12, Jan Beulich wrote:
>
>> >>> On 11.12.12 at 21:50, Olaf Hering wrote:
>> > backend_changed might be called multiple times, which will leak
>> > be->mode. Make sure it will be called only once. Remove some unneeded
>> > checks. Also
On Wed, Dec 12, Jan Beulich wrote:
> >>> On 11.12.12 at 21:50, Olaf Hering wrote:
> > backend_changed might be called multiple times, which will leak
> > be->mode. Make sure it will be called only once. Remove some unneeded
> > checks. Also the be->mode string was leaked, release the memory on
>
>>> On 11.12.12 at 21:50, Olaf Hering wrote:
> backend_changed might be called multiple times, which will leak
> be->mode. Make sure it will be called only once. Remove some unneeded
> checks. Also the be->mode string was leaked, release the memory on
> device shutdown.
So did I miss some
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was leaked, release the memory on
device shutdown.
So did I miss some
On Wed, Dec 12, Jan Beulich wrote:
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was leaked, release the memory on
On 12.12.12 at 10:47, Olaf Hering o...@aepfle.de wrote:
On Wed, Dec 12, Jan Beulich wrote:
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote:
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was leaked,
On Wed, Dec 12, Ian Campbell wrote:
On Wed, 2012-12-12 at 09:42 +, Jan Beulich wrote:
On 11.12.12 at 21:50, Olaf Hering o...@aepfle.de wrote:
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
backend_changed might be called multiple times, which will leak
be->mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be->mode string was leaked, release the memory on
device shutdown.
Signed-off-by: Olaf Hering
---
incorporate all comments from Jan.
fold the
backend_changed might be called multiple times, which will leak
be-mode. Make sure it will be called only once. Remove some unneeded
checks. Also the be-mode string was leaked, release the memory on
device shutdown.
Signed-off-by: Olaf Hering o...@aepfle.de
---
incorporate all comments from Jan.
16 matches
Mail list logo