Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Stefano Stabellini
On Mon, 16 May 2016, Boris Ostrovsky wrote: > On 05/16/2016 07:23 AM, Stefano Stabellini wrote: > > On Wed, 27 Apr 2016, Boris Ostrovsky wrote: > >> On 04/27/2016 09:40 AM, David Vrabel wrote: > >>> On 27/04/16 14:38, Boris Ostrovsky wrote: > int xen_nr_legacy_irqs() > { > if

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Stefano Stabellini
On Mon, 16 May 2016, Boris Ostrovsky wrote: > On 05/16/2016 07:23 AM, Stefano Stabellini wrote: > > On Wed, 27 Apr 2016, Boris Ostrovsky wrote: > >> On 04/27/2016 09:40 AM, David Vrabel wrote: > >>> On 27/04/16 14:38, Boris Ostrovsky wrote: > int xen_nr_legacy_irqs() > { > if

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Boris Ostrovsky
On 05/16/2016 07:23 AM, Stefano Stabellini wrote: > On Wed, 27 Apr 2016, Boris Ostrovsky wrote: >> On 04/27/2016 09:40 AM, David Vrabel wrote: >>> On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs();

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Boris Ostrovsky
On 05/16/2016 07:23 AM, Stefano Stabellini wrote: > On Wed, 27 Apr 2016, Boris Ostrovsky wrote: >> On 04/27/2016 09:40 AM, David Vrabel wrote: >>> On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs();

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Stefano Stabellini
On Wed, 27 Apr 2016, Boris Ostrovsky wrote: > On 04/27/2016 09:40 AM, David Vrabel wrote: > > On 27/04/16 14:38, Boris Ostrovsky wrote: > > > int xen_nr_legacy_irqs() > > > { > > > if (xen_hvm_domain()) > > > return nr_legacy_irqs(); > > > if (xen_initial_domain()) > > >

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-05-16 Thread Stefano Stabellini
On Wed, 27 Apr 2016, Boris Ostrovsky wrote: > On 04/27/2016 09:40 AM, David Vrabel wrote: > > On 27/04/16 14:38, Boris Ostrovsky wrote: > > > int xen_nr_legacy_irqs() > > > { > > > if (xen_hvm_domain()) > > > return nr_legacy_irqs(); > > > if (xen_initial_domain()) > > >

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 09:40 AM, David Vrabel wrote: On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs(); if (xen_initial_domain()) return NR_IRQS_LEGACY; return 0; } Yeah, if that does the right thing...

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 09:40 AM, David Vrabel wrote: On 27/04/16 14:38, Boris Ostrovsky wrote: int xen_nr_legacy_irqs() { if (xen_hvm_domain()) return nr_legacy_irqs(); if (xen_initial_domain()) return NR_IRQS_LEGACY; return 0; } Yeah, if that does the right thing...

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 14:38, Boris Ostrovsky wrote: > > int xen_nr_legacy_irqs() > { > if (xen_hvm_domain()) > return nr_legacy_irqs(); > if (xen_initial_domain()) > return NR_IRQS_LEGACY; > return 0; > } Yeah, if that does the right thing... David

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 14:38, Boris Ostrovsky wrote: > > int xen_nr_legacy_irqs() > { > if (xen_hvm_domain()) > return nr_legacy_irqs(); > if (xen_initial_domain()) > return NR_IRQS_LEGACY; > return 0; > } Yeah, if that does the right thing... David

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 05:35 AM, David Vrabel wrote: On 27/04/16 06:02, Juergen Gross wrote: On 21/04/16 11:30, Stefano Stabellini wrote: On Thu, 21 Apr 2016, Juergen Gross wrote: On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread Boris Ostrovsky
On 04/27/2016 05:35 AM, David Vrabel wrote: On 27/04/16 06:02, Juergen Gross wrote: On 21/04/16 11:30, Stefano Stabellini wrote: On Thu, 21 Apr 2016, Juergen Gross wrote: On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 06:02, Juergen Gross wrote: > On 21/04/16 11:30, Stefano Stabellini wrote: >> On Thu, 21 Apr 2016, Juergen Gross wrote: >>> On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 06:02, Juergen Gross wrote: > On 21/04/16 11:30, Stefano Stabellini wrote: >> On Thu, 21 Apr 2016, Juergen Gross wrote: >>> On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-26 Thread Juergen Gross
On 21/04/16 11:30, Stefano Stabellini wrote: > On Thu, 21 Apr 2016, Juergen Gross wrote: >> On 20/04/16 15:15, Stefano Stabellini wrote: >>> b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number >>> of legacy interrupts when actually nr_legacy_irqs() returns 0 after >>>

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-26 Thread Juergen Gross
On 21/04/16 11:30, Stefano Stabellini wrote: > On Thu, 21 Apr 2016, Juergen Gross wrote: >> On 20/04/16 15:15, Stefano Stabellini wrote: >>> b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number >>> of legacy interrupts when actually nr_legacy_irqs() returns 0 after >>>

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Olaf Hering
On Wed, Apr 20, Stefano Stabellini wrote: > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > probe_8259A(). Use NR_IRQS_LEGACY instead. > > Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Olaf Hering
On Wed, Apr 20, Stefano Stabellini wrote: > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > probe_8259A(). Use NR_IRQS_LEGACY instead. > > Signed-off-by: Stefano Stabellini Tested-by: Olaf Hering

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Stefano Stabellini
On Thu, 21 Apr 2016, Juergen Gross wrote: > On 20/04/16 15:15, Stefano Stabellini wrote: > > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > > probe_8259A(). Use NR_IRQS_LEGACY instead. > > Would

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Stefano Stabellini
On Thu, 21 Apr 2016, Juergen Gross wrote: > On 20/04/16 15:15, Stefano Stabellini wrote: > > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > > probe_8259A(). Use NR_IRQS_LEGACY instead. > > Would

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Juergen Gross
On 20/04/16 15:15, Stefano Stabellini wrote: > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > probe_8259A(). Use NR_IRQS_LEGACY instead. Would you mind describing the resulting problem? With this

Re: [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-21 Thread Juergen Gross
On 20/04/16 15:15, Stefano Stabellini wrote: > b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number > of legacy interrupts when actually nr_legacy_irqs() returns 0 after > probe_8259A(). Use NR_IRQS_LEGACY instead. Would you mind describing the resulting problem? With this

[PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-20 Thread Stefano Stabellini
b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually nr_legacy_irqs() returns 0 after probe_8259A(). Use NR_IRQS_LEGACY instead. Signed-off-by: Stefano Stabellini diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c

[PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-20 Thread Stefano Stabellini
b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually nr_legacy_irqs() returns 0 after probe_8259A(). Use NR_IRQS_LEGACY instead. Signed-off-by: Stefano Stabellini diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index beac4df..349b8ce