Hi Darrick, Brian and Christoph
Ping. I hope to get your feedback.
1) I have confirmed that the following patch set did not change the test
result of generic/470 with thin-volume. Besides, I didn't see any
failure when running generic/470 based on normal PMEM device instaed of
thin-volume.
On 2022/9/15 18:14, Yang, Xiao/杨 晓 wrote:
On 2022/9/15 0:28, Darrick J. Wong wrote:
On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote:
On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote:
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
On 2022/9/9 21:01, Brian Foster wrote:
On 2022/9/15 0:28, Darrick J. Wong wrote:
On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote:
On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote:
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
On 2022/9/9 21:01, Brian Foster wrote:
Yes.. I don't recall all the internals of
On Wed, Sep 14, 2022 at 08:34:26AM -0400, Brian Foster wrote:
> On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote:
> > On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
> > > On 2022/9/9 21:01, Brian Foster wrote:
> > > > Yes.. I don't recall all the internals of the tools and test, but IIRC
On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote:
> On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
> > On 2022/9/9 21:01, Brian Foster wrote:
> > > Yes.. I don't recall all the internals of the tools and test, but IIRC
> > > it relied on discard to perform zeroing between checkpoints or
On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote:
On 2022/9/9 21:01, Brian Foster wrote:
Yes.. I don't recall all the internals of the tools and test, but IIRC
it relied on discard to perform zeroing between checkpoints or some such
and avoid spurious failures. The purpose of running on dm-thin was
On 2022/9/9 21:01, Brian Foster wrote:
Yes.. I don't recall all the internals of the tools and test, but IIRC
it relied on discard to perform zeroing between checkpoints or some such
and avoid spurious failures. The purpose of running on dm-thin was
merely to provide reliable discard zeroing
On Thu, Sep 08, 2022 at 09:46:04PM +0800, Shiyang Ruan wrote:
>
>
> 在 2022/8/4 8:51, Darrick J. Wong 写道:
> > On Wed, Aug 03, 2022 at 06:47:24AM +, ruansy.f...@fujitsu.com wrote:
>
> ...
>
> > > > > > >
> > > > > > > BTW, since these patches (dax + THIS + pmem-unbind)
> > > > > > > are
>
在 2022/8/4 8:51, Darrick J. Wong 写道:
On Wed, Aug 03, 2022 at 06:47:24AM +, ruansy.f...@fujitsu.com wrote:
...
BTW, since these patches (dax + THIS + pmem-unbind) are
waiting to be merged, is it time to think about "removing the
experimental tag" again? :)
It's probably time to
在 2022/8/4 8:51, Darrick J. Wong 写道:
On Wed, Aug 03, 2022 at 06:47:24AM +, ruansy.f...@fujitsu.com wrote:
在 2022/7/29 12:54, Darrick J. Wong 写道:
On Fri, Jul 29, 2022 at 03:55:24AM +, ruansy.f...@fujitsu.com wrote:
在 2022/7/22 0:16, Darrick J. Wong 写道:
On Thu, Jul 21, 2022 at
On Wed, Aug 03, 2022 at 06:47:24AM +, ruansy.f...@fujitsu.com wrote:
>
>
> 在 2022/7/29 12:54, Darrick J. Wong 写道:
> > On Fri, Jul 29, 2022 at 03:55:24AM +, ruansy.f...@fujitsu.com wrote:
> >>
> >>
> >> 在 2022/7/22 0:16, Darrick J. Wong 写道:
> >>> On Thu, Jul 21, 2022 at 02:06:10PM +,
在 2022/7/29 12:54, Darrick J. Wong 写道:
> On Fri, Jul 29, 2022 at 03:55:24AM +, ruansy.f...@fujitsu.com wrote:
>>
>>
>> 在 2022/7/22 0:16, Darrick J. Wong 写道:
>>> On Thu, Jul 21, 2022 at 02:06:10PM +, ruansy.f...@fujitsu.com wrote:
在 2022/7/1 8:31, Darrick J. Wong 写道:
> On Thu,
On Fri, Jul 29, 2022 at 03:55:24AM +, ruansy.f...@fujitsu.com wrote:
>
>
> 在 2022/7/22 0:16, Darrick J. Wong 写道:
> > On Thu, Jul 21, 2022 at 02:06:10PM +, ruansy.f...@fujitsu.com wrote:
> >> 在 2022/7/1 8:31, Darrick J. Wong 写道:
> >>> On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan
在 2022/7/22 0:16, Darrick J. Wong 写道:
> On Thu, Jul 21, 2022 at 02:06:10PM +, ruansy.f...@fujitsu.com wrote:
>> 在 2022/7/1 8:31, Darrick J. Wong 写道:
>>> On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
Failure notification is not supported on partitions. So, when we mount
On Thu, Jul 21, 2022 at 02:06:10PM +, ruansy.f...@fujitsu.com wrote:
> 在 2022/7/1 8:31, Darrick J. Wong 写道:
> > On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
> >> Failure notification is not supported on partitions. So, when we mount
> >> a reflink enabled xfs on a partition
在 2022/7/1 8:31, Darrick J. Wong 写道:
> On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
>> Failure notification is not supported on partitions. So, when we mount
>> a reflink enabled xfs on a partition with dax option, let it fail with
>> -EINVAL code.
>>
>> Signed-off-by: Shiyang
Hi Andrew,
I am not sure if you had seen this. So make a ping.
在 2022/7/1 13:14, Shiyang Ruan 写道:
>
>
> 在 2022/7/1 8:31, Darrick J. Wong 写道:
>> On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
>>> Failure notification is not supported on partitions. So, when we mount
>>> a
在 2022/7/1 8:31, Darrick J. Wong 写道:
On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
Failure notification is not supported on partitions. So, when we mount
a reflink enabled xfs on a partition with dax option, let it fail with
-EINVAL code.
Signed-off-by: Shiyang Ruan
On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
> Failure notification is not supported on partitions. So, when we mount
> a reflink enabled xfs on a partition with dax option, let it fail with
> -EINVAL code.
>
> Signed-off-by: Shiyang Ruan
Looks good to me, though I think this
On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote:
> Failure notification is not supported on partitions. So, when we mount
> a reflink enabled xfs on a partition with dax option, let it fail with
> -EINVAL code.
Looks good:
Reviewed-by: Christoph Hellwig
Failure notification is not supported on partitions. So, when we mount
a reflink enabled xfs on a partition with dax option, let it fail with
-EINVAL code.
Signed-off-by: Shiyang Ruan
---
fs/xfs/xfs_super.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
21 matches
Mail list logo
